Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready-made html code and css styles for the task Search bar for Airbnb #4751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kilv7
Copy link

@Kilv7 Kilv7 commented Feb 3, 2025

[x] Icon implemented using background-image CSS property
[x] Inputs are written inside of 'form' tag with correctly passed attributes
[x] All Typical Mistakes from BEM lesson theory are checked.
[x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on your submission! 🎉 Your code is well-structured and meets most of the task requirements. While there are a few minor issues, such as the use of the * selector and the need for fallback fonts in the font-family property, these do not critically impact the functionality of your code. Remember to keep lines under 80 characters for readability and consider defining 'Avenir' with the appropriate font-weight instead of 'Avenir-Heavy'. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


.search-bar-input:focus {
outline: none;
font-family: Avenir-Heavy, sans-serif;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-family 'Avenir-Heavy' is not defined as a separate font-family in the @font-face declarations. You should use 'Avenir' with the appropriate font-weight to achieve the desired style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants