-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project in process #4018
project in process #4018
Conversation
ViktorTsupa
commented
Jan 11, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/index.html
Outdated
</div> | ||
</div> | ||
<div class="stars"> | ||
<div class="stars__star stars--5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use your modifiers only for stars
block not for elements. The same like you used for stars--0
src/index.html
Outdated
<div class="stars stars--0"> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
</div> | ||
<div class="stars"> | ||
<div class="stars__star stars--1"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
<div class="stars__star"> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="stars stars--0"> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
</div> | |
<div class="stars"> | |
<div class="stars__star stars--1"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
</div> | |
<div class="stars stars--0"> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
</div> | |
<div class="stars"> | |
<div class="stars__star stars--1"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
<div class="stars__star"> | |
</div> | |
</div> |
it is a good idea making blank line between multiline siblings. check guide line Check everywhere
|
edited according to your comments, please review again, thank you 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Almost done!
height: 16px; | ||
} | ||
|
||
.stars--2 li:nth-child(-1n + 2)::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.stars--2 li:nth-child(-1n + 2)::after { | |
.stars--2 li:nth-child(-1n + 2)::after, | |
... { |
Consider using commas to group your selectors and avoid repeating code