Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project in process #4018

Closed
wants to merge 4 commits into from
Closed

Conversation

ViktorTsupa
Copy link

Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Check my comments
  2. fix styles for modifiers (use nth-child selectors for applying proper image for stars`
  3. Try to pass all tests
    This is how your layout looks like now
    image

src/index.html Outdated
</div>
</div>
<div class="stars">
<div class="stars__star stars--5">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use your modifiers only for stars block not for elements. The same like you used for stars--0

src/index.html Outdated
Comment on lines 13 to 36
<div class="stars stars--0">
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>
<div class="stars">
<div class="stars__star stars--1">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="stars stars--0">
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>
<div class="stars">
<div class="stars__star stars--1">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>
<div class="stars stars--0">
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>
<div class="stars">
<div class="stars__star stars--1">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
<div class="stars__star">
</div>
</div>

it is a good idea making blank line between multiline siblings. check guide line Check everywhere

@ViktorTsupa
Copy link
Author

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@ViktorTsupa
Copy link
Author

edited according to your comments, please review again, thank you 😃

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

height: 16px;
}

.stars--2 li:nth-child(-1n + 2)::after {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.stars--2 li:nth-child(-1n + 2)::after {
.stars--2 li:nth-child(-1n + 2)::after,
... {

Consider using commas to group your selectors and avoid repeating code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants