-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5165
base: master
Are you sure you want to change the base?
add task solution #5165
Conversation
NadiiaBulmak
commented
Dec 17, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the star rating system! 🌟 Your code meets the core requirements, and the functionality is intact. While there are a couple of minor suggestions, such as the use of justify-content
and align-content
properties, these don't impact the overall functionality. Keep up the good work, and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/style.css
Outdated
.stars { | ||
display: flex; | ||
flex-direction: row; | ||
align-content: space-between; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The align-content
property is used for multi-line flex containers. Since the .stars
container is likely a single line, this property may not have any effect. Consider removing it if it's not needed.
src/style.css
Outdated
background-repeat: no-repeat; | ||
width: 16px; | ||
height: 16px; | ||
justify-content: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The justify-content
property is not applicable to individual flex items like .stars__star
. It should be applied to the flex container instead. Consider removing it from here.