Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5172

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Develop #5172

wants to merge 7 commits into from

Conversation

ochepurna
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is almost there, but there are a few critical issues that need to be addressed before we can approve it. 🌟 Specifically, the stars--0 block needs to have no active stars, and the CSS should ensure no vertical margins between blocks. Additionally, each BEM block should have its own CSS file. These changes are important to meet the core requirements of the task. Keep up the great work, and I'm confident you'll nail it with these adjustments! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on addressing most of the issues from the previous review! 🎉 Your code now meets the task requirements and constraints, which is a significant step forward. Here are a few points to keep in mind:

  1. BEM Block CSS Files: You've correctly created separate CSS files for each stars--N modifier. This is in line with the task requirements. Keep up the good work!

  2. Stars--0 Block: The HTML structure for the stars--0 block is correct, as it contains no active stars. However, ensure that the CSS for this block reflects this requirement to maintain consistency.

  3. CSS Vertical Margins: You've successfully ensured that there are no vertical margins between blocks, which is great. The CSS file style.css correctly sets margin-bottom and margin-top to 0 for the .stars class.

  4. Unrelated Files: All files are relevant to the task, which is excellent.

While your solution is approved, please review the comments to improve your code further. Addressing these critical points will help you avoid similar issues in the future. Keep learning and refining your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +40 to +46
<div class="stars stars--0">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stars--0 block should have no active stars. Ensure that the CSS for this block reflects this requirement.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
You don't need to create separate files for each selector, these selectors should be combined into one file separated by commas.
image

src/stars--N.css Outdated
Comment on lines 13 to 15
.stars--5 {
margin-bottom: 0;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need that

src/style.css Outdated
Comment on lines 7 to 8
margin-bottom: 0;
margin-top: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants