Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nikol-nuzhna
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [ x ] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • [ x ] Each BEM block has its own separate file

  • [ x ] All Typical Mistakes from BEM lesson theory are checked.

  • [ x ] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is almost there! 🎉 However, there are a couple of critical issues that need to be addressed before we can approve it. Specifically, you need to use pseudo-selectors for styling the yellow stars as per the requirements, and separate the BEM block styles into individual files. These changes are essential to meet the core requirements of the task. Once you make these adjustments, your implementation will be spot on! Keep up the great work, and don't hesitate to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the previous issues with pseudo-selectors and separating BEM block styles! 🎉 However, there are still a couple of points to improve:

  1. BEM Block Styles: Ensure each BEM block has its own separate CSS file as per the requirements. Currently, all styles are in a single style.css file.

  2. Images for Stars: Make sure the images for the stars are included in an images folder and correctly referenced in your project.

These adjustments will help align your implementation more closely with the task requirements. Keep up the good work, and remember to review the comments to enhance your code further. Addressing these issues will be crucial for future tasks. Keep learning and improving! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants