Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5265

wants to merge 1 commit into from

Conversation

nxqar
Copy link

@nxqar nxqar commented Jan 13, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your implementation! 🎉 The HTML and CSS structure is well-formed and meets most of the task requirements. While there is a minor issue with the CSS selector for the stars--0 class, it doesn't critically impact the functionality. Consider adjusting the selector as suggested to ensure it aligns with your design intentions. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +21 to +23
.stars--0 .stars__star:nth-child(-n + 0) {
background-image: url(images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector '.stars--0 .stars__star:nth-child(-n + 0)' does not apply any active stars because '-n + 0' results in no elements being selected. Consider changing it to '.stars--0 .stars__star:nth-child(-n + 1)' if you want at least one star to be active, or adjust according to your design requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants