-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #5277
base: master
Are you sure you want to change the base?
add solution #5277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your implementation is mostly on the right track, there are a few critical issues that need to be addressed before we can approve the pull request:
-
CSS Selector Errors: The use of spaces in selectors like
.stars--1 :first-child
and.stars__star :last-child
is incorrect. These spaces cause the pseudo-classes to apply to children of the selected elements rather than the elements themselves. This impacts the functionality of your star rating system, so it's important to correct these selectors by removing the spaces. -
CSS Best Practices: The use of the universal selector
*
and tag name selectors should be avoided as they can impact performance and are not recommended except forhtml
andbody
. -
BEM Methodology: Each BEM block should ideally have its own separate file. This helps in maintaining a clean and organized codebase.
Please address these issues to ensure your code meets the task requirements. Once these changes are made, feel free to resubmit your pull request. Keep up the great work, and I'm confident you'll nail it! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/style.css
Outdated
margin-right: 4px; | ||
} | ||
|
||
.stars__star :last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selector '.stars__star :last-child' is incorrect. There should not be a space between '.stars__star' and ':last-child'. It should be '.stars__star:last-child' to correctly target the last child of '.stars__star'.
.stars--1 :first-child, | ||
.stars--2 :nth-child(-n + 2), | ||
.stars--3 :nth-child(-n + 3), | ||
.stars--4 :nth-child(-n + 4), | ||
.stars--5 :nth-child(-n + 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selectors '.stars--1 :first-child', '.stars--2 :nth-child(-n + 2)', etc., have a space before the pseudo-classes. This space indicates that the pseudo-class applies to a child of the selected element, not the element itself. If the intention is to style the stars directly, remove the space before ':first-child', ':nth-child(-n + 2)', etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great effort on implementing the star rating system using BEM methodology! 🌟 Your HTML structure is solid, and you've made some good corrections in your CSS. However, there are a few critical points to address:
-
CSS Selector Errors: The pseudo-classes like
:first-child
and:nth-child
should be applied to the.stars__star
elements, not the.stars
elements. This adjustment is crucial for the intended styling to apply correctly. -
Universal Selector Usage: The use of the universal selector
*
for resetting styles is not recommended due to potential performance impacts. It's better to target specific elements or use a more efficient method for resetting styles. -
BEM Methodology: While your HTML follows BEM, the CSS could be better organized. Consider separating each BEM block into its own file for clarity and maintainability.
Remember, the decision to approve is to help you move forward with your learning journey. Please review the comments and make improvements to your code. Addressing these issues will enhance your skills and ensure your code is robust and efficient. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -1 +1,31 @@ | |||
/* add styles here */ | |||
* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the universal selector *
is not recommended as it can impact performance. Consider applying these styles to specific elements instead.
src/style.css
Outdated
.stars--1:first-child, | ||
.stars--2:nth-child(-n + 2), | ||
.stars--3:nth-child(-n + 3), | ||
.stars--4:nth-child(-n + 4), | ||
.stars--5:nth-child(-n + 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selectors here are incorrect. The pseudo-classes like :first-child
and :nth-child
should be applied to the .stars__star
elements, not the .stars
elements. This is likely causing the intended styling to not apply correctly.
No description provided.