Develop #5377
Open
Develop #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Great job! 🎉 Your implementation meets all the task requirements and constraints perfectly. The HTML and CSS are well-structured, and you've followed the BEM methodology correctly. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
anastasiiavorobiova
suggested changes
Feb 8, 2025
src/style.css
Outdated
Comment on lines
13
to
16
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| height: 100vh; |
There was a problem hiding this comment.
Suggested change
| display: flex; | |
| justify-content: center; | |
| align-items: center; | |
| height: 100vh; |
There was a problem hiding this comment.
Redundant classes which can break tests
src/style.css
Outdated
Comment on lines
24
to
27
| align-items: center; | ||
| justify-content: center; | ||
| width: calc(5 * (var(--star-size) + var(--star-spacing))); | ||
| height: calc(5 * (var(--star-size) + var(--row-spacing))); |
There was a problem hiding this comment.
Suggested change
| align-items: center; | |
| justify-content: center; | |
| width: calc(5 * (var(--star-size) + var(--star-spacing))); | |
| height: calc(5 * (var(--star-size) + var(--row-spacing))); |
src/style.css
Outdated
Comment on lines
52
to
54
| opacity: 1; | ||
| padding: 0; | ||
| margin: 0; |
There was a problem hiding this comment.
Suggested change
| opacity: 1; | |
| padding: 0; | |
| margin: 0; |
added 2 commits
February 8, 2025 13:46
Reference Test Diff label: stars--0selector: .stars--0 filename: stars--0.png diff%: 9.06 diff-x: 0 diff-y: 0 Reference Test Diff label: stars--1selector: .stars--1 filename: stars--1.png diff%: 11.25 diff-x: 0 diff-y: 0 Reference Test Diff label: stars--2selector: .stars--2 filename: stars--2.png diff%: 13.44 diff-x: 0 diff-y: 0 Reference Test Diff label: stars--3selector: .stars--3 filename: stars--3.png diff%: 15.63 diff-x: 0 diff-y: 0 Reference Test Diff label: stars--4selector: .stars--4 filename: stars--4.png diff%: 17.81 diff-x: 0 diff-y: 0 Reference Test Diff label: stars--5selector: .stars--5 filename: stars--5.png diff%: 20.00 diff-x: 0 diff-y: 0 Reference Test Diff
vadiimvooo
suggested changes
Feb 8, 2025
src/style.css
Outdated
Comment on lines
13
to
16
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| height: 100vh; |
| background-position: center; | ||
| background-image: url('/src/images/star.svg'); /* Default star */ | ||
| flex-shrink: 0; | ||
| margin-right: var(--star-spacing); |
vadiimvooo
suggested changes
Feb 8, 2025
src/style.css
Outdated
Comment on lines
13
to
16
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| height: 100vh; |
There was a problem hiding this comment.
Redundant classes which can break tests
| background-position: center; | ||
| background-image: url('/src/images/star.svg'); /* Default star */ | ||
| flex-shrink: 0; | ||
| margin-right: var(--star-spacing); |
anastasiiavorobiova
approved these changes
Feb 9, 2025
src/index.html
Outdated
Comment on lines
52
to
57
| <div class="stars stars--5"> | ||
| <div class="stars__star active"></div> | ||
| <div class="stars__star active"></div> | ||
| <div class="stars__star active"></div> | ||
| <div class="stars__star active"></div> | ||
| <div class="stars__star active"></div> |
There was a problem hiding this comment.
Suggested change
| <div class="stars stars--5"> | |
| <div class="stars__star active"></div> | |
| <div class="stars__star active"></div> | |
| <div class="stars__star active"></div> | |
| <div class="stars__star active"></div> | |
| <div class="stars__star active"></div> | |
| <div class="stars stars--5"> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> | |
| <div class="stars__star"></div> |
added 2 commits
February 10, 2025 05:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
❗️ Replace
<your_account>with your Github username and copy the links toPull Requestdescription:❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.Typical MistakesfromBEMlesson theory are checked.