-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5383
base: master
Are you sure you want to change the base?
add task solution #5383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! 😊 It looks like you've done a great job on most parts of the task, but there's a critical issue that needs to be addressed before we can approve your pull request. The path to the CSS file staras.css
seems to be incorrect, which is preventing the styles from being applied properly. Additionally, it seems like there might be a typo in the file name itself, as it should be stars.css
to match the BEM block name stars
.
Please correct the file path and name to ensure everything works as expected. Once these changes are made, your solution should be good to go! Keep up the great work, and I'm sure you'll have this sorted out in no time! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/index.html
Outdated
href="style/block/staras.css" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path 'style/block/staras.css' seems to be incorrect. Please verify the correct path to the 'staras.css' file to ensure the stylesheet is loaded properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on your implementation! 🎉 Your HTML and CSS files are well-structured and mostly meet the task requirements. However, there's a critical issue with the path to the CSS file stars.css
. Please ensure that the file is located in the specified path ../src/style/block/
and update the path in your HTML file if necessary. This will ensure that the styles are applied correctly.
Your CSS files, stars.css
and style.css
, are well-organized and implement the required styles effectively. The use of display: flex
for the stars
block is correct, and the BEM methodology is followed properly with separate files for each block.
The decision to approve your pull request is made to help you move forward with your learning journey. Please review the comments and address the critical issue with the CSS file path to enhance the functionality of your code. Keep up the great work, and continue to learn from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
href="../src/style/block/stars.css" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path to the CSS file seems to be incorrect. Ensure that the file stars.css
is located in the specified path ../src/style/block/
. If the file name or directory is different, please update the path accordingly.
DEMO LINK
TEST REPORT LINK
[X ] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
[ X] Each BEM block has its own separate file
[X ] All
Typical Mistakes
fromBEM
lesson theory are checked.[X ] Code follows all the Code Style Rules ❗️