Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #323

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #323

wants to merge 3 commits into from

Conversation

eduvinagre
Copy link

No description provided.

Copy link

@jv-aquino jv-aquino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job edu, just minor cleanings that could be done

src/app.js Outdated
if (err) {
console.error('Error copying file:', err);

return;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could just return the console.log

src/app.js Outdated
if (path.resolve(src) === path.resolve(dest)) {
console.log('Source and destination are the same. No action taken.');

return;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

}

const sourceFilePath = process.argv[2];
const destinationFilePath = process.argv[3];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this could be done in 1 line, but this way is better

@eduvinagre eduvinagre requested a review from jv-aquino June 25, 2024 19:44
@eduvinagre
Copy link
Author

Tks for the review @jv-aquino

Copy link

@jv-aquino jv-aquino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants