Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developed #365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NazariiAlieksieiev
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the file copy functionality! 🎉 The code meets the task requirements effectively. However, consider adding a message when the source and destination are the same, and ensure you handle the file existence check properly to make your code even more robust. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


function copyFile(copyFrom, copyTo) {
try {
fs.existsSync(copyFrom);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fs.existsSync(copyFrom); line is not being used correctly. This function returns a boolean indicating whether the file exists, but here it is not being checked. You should use it in a conditional statement to handle the case where the file does not exist.

console.error(error);
}

if (copyFrom === copyTo) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check if (copyFrom === copyTo) is correct in terms of logic, but it might be beneficial to log a message indicating that the source and destination are the same, and therefore no action will be taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants