Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #708

wants to merge 1 commit into from

Conversation

VladyslavBon
Copy link

No description provided.

@property
def full_name(self):
return f"{self.first_name} {self.last_name}"

def __str__(self):
return self.first_name + " " + self.last_name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use full_name property in this method: return self.full_name.

Comment on lines +14 to +22
router.register("genres", GenreViewSet, basename="genres")
router.register("actors", ActorViewSet, basename="actors")
router.register("cinema_halls", CinemaHallViewSet, basename="cinema_halls")
router.register("movies", MovieViewSet, basename="movies")
router.register(
"movie_sessions",
MovieSessionViewSet,
basename="movie_sessions"
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep router registrations consistent - use single-line format for all, or multi-line format for all.
Currently, movie_sessions differs from others.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 The code is well-structured and meets most of the task requirements. There are a few minor issues to address in the future, such as adding type annotations to class methods and avoiding unnecessary use of .all() before .prefetch_related() and .select_related(). Also, remember to exclude unrelated migration files from the task. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants