-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #726
Open
VolodymyrSemchysyn
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
VolodymyrSemchysyn:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #726
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,83 @@ | ||
# write serializers here | ||
from rest_framework import serializers | ||
from cinema.models import CinemaHall, Genre, Actor, Movie, MovieSession | ||
|
||
|
||
class CinemaHallSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = CinemaHall | ||
fields = ("id", "name", "rows", "seats_in_row", "capacity") | ||
|
||
|
||
class GenreSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = Genre | ||
fields = ("id", "name") | ||
|
||
|
||
class ActorSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = Actor | ||
fields = ("id", "first_name", "last_name", "full_name") | ||
|
||
|
||
class MovieSerializer(serializers.ModelSerializer): | ||
class Meta: | ||
model = Movie | ||
fields = ("id", "title", "description", "duration", "genres", "actors") | ||
|
||
|
||
class MovieListSerializer(MovieSerializer): | ||
genres = serializers.SlugRelatedField( | ||
many=True, | ||
read_only=True, | ||
slug_field="name" | ||
) | ||
actors = serializers.SlugRelatedField( | ||
many=True, | ||
read_only=True, | ||
slug_field="full_name" | ||
) | ||
|
||
|
||
class MovieDetailSerializer(MovieSerializer): | ||
genres = GenreSerializer(many=True, read_only=True) | ||
actors = ActorSerializer(many=True, read_only=True) | ||
|
||
|
||
class MovieSessionSerializer(serializers.ModelSerializer): | ||
movie = serializers.PrimaryKeyRelatedField(queryset=Movie.objects.all()) | ||
cinema_hall = (serializers. | ||
PrimaryKeyRelatedField | ||
(queryset=CinemaHall.objects.all())) | ||
|
||
class Meta: | ||
model = MovieSession | ||
fields = ("show_time", "movie", "cinema_hall") | ||
|
||
|
||
class MovieSessionListSerializer(MovieSessionSerializer): | ||
movie_title = serializers.CharField( | ||
source="movie.title", | ||
read_only=True | ||
) | ||
cinema_hall_name = serializers.CharField( | ||
source="cinema_hall.name", | ||
read_only=True | ||
) | ||
cinema_hall_capacity = serializers.IntegerField( | ||
source="cinema_hall.capacity", | ||
read_only=True | ||
) | ||
|
||
class Meta: | ||
model = MovieSession | ||
fields = ( | ||
"id", "show_time", | ||
"movie_title", "cinema_hall_name", | ||
"cinema_hall_capacity" | ||
) | ||
|
||
|
||
class MovieSessionDetailSerializer(MovieSessionSerializer): | ||
movie = MovieListSerializer(many=False, read_only=True) | ||
cinema_hall = CinemaHallSerializer(many=False, read_only=True) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,27 @@ | ||
# write urls here | ||
from django.urls import path, include | ||
from rest_framework import routers | ||
|
||
from cinema.views import ( | ||
CinemaHallViewSet, | ||
GenreViewSet, | ||
ActorViewSet, | ||
MovieViewSet, | ||
MovieSessionViewSet | ||
) | ||
|
||
router = routers.DefaultRouter() | ||
router.register("cinema_halls", CinemaHallViewSet) | ||
router.register("genres", GenreViewSet) | ||
router.register("actors", ActorViewSet) | ||
router.register("movies", MovieViewSet, basename="movie") | ||
router.register( | ||
"movie_sessions", | ||
MovieSessionViewSet, | ||
basename="movie_session" | ||
) | ||
|
||
urlpatterns = [ | ||
path("", include(router.urls)) | ||
] | ||
|
||
app_name = "cinema" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,60 @@ | ||
# write views here | ||
from rest_framework import viewsets | ||
from cinema.models import CinemaHall, Genre, Actor, Movie, MovieSession | ||
from cinema.serializers import ( | ||
CinemaHallSerializer, GenreSerializer, | ||
ActorSerializer, MovieSerializer, | ||
MovieSessionSerializer, MovieListSerializer, | ||
MovieDetailSerializer, MovieSessionListSerializer, | ||
MovieSessionDetailSerializer | ||
) | ||
|
||
|
||
class CinemaHallViewSet(viewsets.ModelViewSet): | ||
queryset = CinemaHall.objects.all() | ||
serializer_class = CinemaHallSerializer | ||
|
||
|
||
class GenreViewSet(viewsets.ModelViewSet): | ||
queryset = Genre.objects.all() | ||
serializer_class = GenreSerializer | ||
|
||
|
||
class ActorViewSet(viewsets.ModelViewSet): | ||
queryset = Actor.objects.all() | ||
serializer_class = ActorSerializer | ||
|
||
|
||
class MovieViewSet(viewsets.ModelViewSet): | ||
queryset = Movie.objects.all() | ||
serializer_class = MovieSerializer | ||
|
||
def get_queryset(self): | ||
queryset = self.queryset | ||
if self.action in ("list", "retrieve"): | ||
return queryset.prefetch_related("genres", "actors") | ||
return queryset | ||
|
||
def get_serializer_class(self): | ||
if self.action == "list": | ||
return MovieListSerializer | ||
if self.action == "retrieve": | ||
return MovieDetailSerializer | ||
return MovieSerializer | ||
|
||
|
||
class MovieSessionViewSet(viewsets.ModelViewSet): | ||
queryset = MovieSession.objects.all() | ||
serializer_class = MovieSessionSerializer | ||
|
||
def get_queryset(self): | ||
queryset = self.queryset | ||
if self.action == "list": | ||
return queryset.select_related("movie", "cinema_hall") | ||
return queryset | ||
|
||
def get_serializer_class(self): | ||
if self.action == "list": | ||
return MovieSessionListSerializer | ||
if self.action == "retrieve": | ||
return MovieSessionDetailSerializer | ||
return MovieSessionSerializer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,7 @@ | |
|
||
USE_I18N = True | ||
|
||
USE_TZ = True | ||
USE_TZ = False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
|
||
# Static files (CSS, JavaScript, Images) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
from django.contrib import admin | ||
from django.urls import path | ||
from django.urls import path, include | ||
|
||
urlpatterns = [ | ||
path("admin/", admin.site.urls), | ||
path("api/cinema/", include("cinema.urls", namespace="cinema")), | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider verifying whether the exclusion of the
id
field from theMovieSessionListSerializer
is intentional. If you need theid
field for identification purposes, you should include it in thefields
list.