Solution #727
Solution #727
Conversation
There was a problem hiding this comment.
Great job on implementing the cinema application! 🎬 Your code is well-structured and meets the task requirements effectively. The models, serializers, views, and URL configurations are all set up correctly, ensuring a smooth and efficient application.
While there is a minor issue with the full_name field in the ActorSerializer not being marked as read-only, this does not significantly impact the functionality of your application. It's a good practice to mark computed properties as read-only to prevent any unintended modifications, so consider adding full_name to the read_only_fields tuple in the future.
Keep up the excellent work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| class ActorSerializer(serializers.ModelSerializer): | ||
| class Meta: | ||
| model = Actor | ||
| fields = ("id", "first_name", "last_name", "full_name") |
There was a problem hiding this comment.
The full_name field in ActorSerializer should be marked as read-only since it is a property and not a model field. Consider adding full_name to the read_only_fields tuple.
| fields = ("id", "show_time", "movie_title", | ||
| "cinema_hall_name", "cinema_hall_capacity") |
There was a problem hiding this comment.
Better to start every argument from a new line, if you have too many fields
No description provided.