Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #732

wants to merge 1 commit into from

Conversation

Bondzik-S
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code meets the core requirements and is mostly well-structured. There are a couple of minor issues to address, such as adding type annotations to class methods and ensuring the use of exclude in MovieSessionListSerializer is intentional. These don't impact the functionality, so I'm approving your PR. Keep up the good work and consider these improvements for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +76 to +78
class Meta:
model = MovieSession
exclude = ["movie", "cinema_hall"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the MovieSessionListSerializer, the Meta class uses exclude to exclude movie and cinema_hall fields. Ensure this is intentional. If you want to specify fields to include, use fields instead of exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants