Develop #750
Develop #750
Conversation
There was a problem hiding this comment.
Great job on implementing the serializers and viewsets! 🎉 While there are a few minor improvements suggested, such as adding type annotations and optimizing queryset usage, these do not impact the core functionality of your code. Keep up the good work and consider the feedback for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -6,3 +6,4 @@ | |||
| venv/ | |||
| .pytest_cache/ | |||
| **__pycache__/ | |||
| db.sqlite3 | |||
There was a problem hiding this comment.
There is an extra space before db.sqlite3. It is recommended to remove this space to ensure the file is properly ignored by Git.
cinema_service/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| path("admin/", admin.site.urls), | ||
| ] | ||
| path("api/", include("cinema.urls", namespace="cinema")), | ||
| ] + debug_toolbar_urls() |
There was a problem hiding this comment.
The debug_toolbar_urls() is added directly to urlpatterns. It's recommended to conditionally include debug toolbar URLs only when DEBUG is True to avoid exposing debug information in production.
No description provided.