Solution #331
Open
Solution #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylhnatiuk
suggested changes
Sep 6, 2023
| migrations.CreateModel( | ||
| name='CinemaHall', | ||
| fields=[ | ||
| ('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), |
cinema/views.py
Outdated
| serializer = MovieSerializer(movie, data=request.data) | ||
| def put(self, request, pk): | ||
| genre = self.get_object(pk) | ||
| serializer = GenreSerializer(genre, data=request.data) | ||
| if serializer.is_valid(): |
There was a problem hiding this comment.
serializer.is_valid(raise_exception=True) use it instead of if serializer.is_valid():
cinema/views.py
Outdated
| MovieSerializer, | ||
| GenreSerializer, | ||
| ActorSerializer, | ||
| CinemaHallSerializer) |
There was a problem hiding this comment.
Suggested change
| CinemaHallSerializer) | |
| CinemaHallSerializer | |
| ) |
vsmutok
suggested changes
Sep 6, 2023
cinema/urls.py
Outdated
Comment on lines
5
to
11
| from cinema.views import (MovieViewSet, | ||
| GenreList, | ||
| GenreDetail, | ||
| ActorList, | ||
| ActorDetail, | ||
| CinemaHallViewSet | ||
| ) |
cinema/urls.py
Outdated
Comment on lines
5
to
11
| from cinema.views import (MovieViewSet, | ||
| GenreList, | ||
| GenreDetail, | ||
| ActorList, | ||
| ActorDetail, | ||
| CinemaHallViewSet | ||
| ) |
There was a problem hiding this comment.
fix everywhere
you can use black
Suggested change
| from cinema.views import (MovieViewSet, | |
| GenreList, | |
| GenreDetail, | |
| ActorList, | |
| ActorDetail, | |
| CinemaHallViewSet | |
| ) | |
| from cinema.views import ( | |
| MovieViewSet, | |
| GenreList, | |
| GenreDetail, | |
| ActorList, | |
| ActorDetail, | |
| CinemaHallViewSet | |
| ) |
cinema/views.py
Outdated
Comment on lines
70
to
72
| class ActorDetail(mixins.RetrieveModelMixin, mixins.UpdateModelMixin, | ||
| mixins.DestroyModelMixin, | ||
| generics.GenericAPIView): |
cinema/views.py
Outdated
| serializer = MovieSerializer(movie, data=request.data) | ||
| def put(self, request, pk): | ||
| genre = self.get_object(pk) | ||
| serializer = GenreSerializer(genre, data=request.data) | ||
| if serializer.is_valid(): |
Yurnerroo
suggested changes
Sep 12, 2023
Comment on lines
24
to
25
| if serializer.is_valid(): | ||
| serializer.save() |
There was a problem hiding this comment.
replace with serializer.is_valid(raise_exception=True) here as well
There was a problem hiding this comment.
Тоді падає тест test_post_genres
vasylhnatiuk
suggested changes
Oct 2, 2023
Comment on lines
24
to
25
| if serializer.is_valid(): | ||
| serializer.save() |
ArsenPidhoretskyi
suggested changes
Oct 13, 2023
cinema/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| path("movies/", movie_list, name="movie-list"), | ||
| path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
| path("", include(router.urls)), |
There was a problem hiding this comment.
No need to include if basepath is not provided. Instead use:
urlpatterns = [list of urls] + router.urls
vsmutok
suggested changes
Oct 14, 2023
cinema/urls.py
Outdated
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
|
|
||
| path("", include(router.urls)), |
There was a problem hiding this comment.
No need to include if basepath is not provided. Instead use:
urlpatterns = [list of urls] + router.urls
vasylhnatiuk
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.