Implemented API #357
Open
Implemented API #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ihor-MA
reviewed
Oct 11, 2023
| @@ -5,6 +5,23 @@ class Movie(models.Model): | |||
| title = models.CharField(max_length=255) | |||
| description = models.TextField() | |||
| duration = models.IntegerField() | |||
| actors = models.ManyToManyField("Actor") | |||
| genres = models.ManyToManyField("Genre") | |||
There was a problem hiding this comment.
for what reason? They are not used
Ihor-MA
reviewed
Oct 11, 2023
| @@ -1,24 +1,27 @@ | |||
| from rest_framework import serializers | |||
|
|
|||
| from cinema.models import Movie | |||
| from cinema.models import Movie, Actor, Genre, CinemaHall | |||
There was a problem hiding this comment.
You can also use relative imports, IMHO it is better
There was a problem hiding this comment.
relative imports are a very bad practice)
Ihor-MA
approved these changes
Oct 11, 2023
Serhii-Leonenko
approved these changes
Oct 12, 2023
Comment on lines
+49
to
52
| if serializer.is_valid(): | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_200_OK) | ||
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) |
There was a problem hiding this comment.
You can simplify it with raise_exceptions = True https://stackoverflow.com/a/40373171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created api for all models with different serializers