'py-api-views' #385
Open
'py-api-views' #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Nov 16, 2023
cinema/urls.py
Outdated
| path("cinema_halls/", cinema_hall_list, name="cinema-hall-list"), | ||
| path("cinema_halls/<int:pk>/", cinema_hall_detail, | ||
| name="cinema-hall-detail"), | ||
| path("", include(router.urls)), |
There was a problem hiding this comment.
No need to use include when basepath is not provided. Use urlpatterns = [list of urls] + router.urls
| def post(self, request): | ||
| serializer = GenreSerializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() |
vsmutok
suggested changes
Nov 17, 2023
Pipfile
Outdated
Comment on lines
2
to
12
| url = "https://pypi.org/simple" | ||
| verify_ssl = true | ||
| name = "pypi" | ||
|
|
||
| [packages] | ||
|
|
||
| [dev-packages] | ||
| pytest-django = "*" | ||
|
|
||
| [requires] | ||
| python_version = "3.11" |
pyproject.toml
Outdated
Comment on lines
2
to
5
| requires = [ | ||
| "setuptools>=61.0.0", | ||
| ] | ||
| build-backend = "setuptools.build_meta" |
ArsenPidhoretskyi
suggested changes
Nov 18, 2023
.gitignore
Outdated
| db.sqlite3 | ||
| Pipfile | ||
| pyproject.toml |
|
|
||
| urlpatterns = [ | ||
| path("movies/", movie_list, name="movie-list"), | ||
| path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
| *router.urls, |
There was a problem hiding this comment.
You can do:
urlpatterns = [list of urls] + router.urls
pytest.ini
Outdated
| addopts = --reuse-db | ||
| django_find_project = false | ||
| pythonpath = . src |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.