Solution #393
Open
Solution #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrykivd
suggested changes
Nov 28, 2023
Comment on lines
+15
to
+16
| def __str__(self) -> str: | ||
| return str(self.name) |
There was a problem hiding this comment.
This is because I add an annotation type, and it has an underline without it
Comment on lines
+24
to
+25
| def __str__(self) -> str: | ||
| return f"{self.name} rows: {self.rows} seats: {self.seats_in_row}" |
There was a problem hiding this comment.
Perhaps it is more logical to return the name of the hall?
There was a problem hiding this comment.
I don't agree, it depends on the task you have, but here is not business logic about that.
cinema/serializers.py
Outdated
Comment on lines
33
to
51
| class GenreSerializer(serializers.ModelSerializer): | ||
|
|
||
| class Meta: | ||
| model = Genre | ||
| fields = ["id", "name"] | ||
|
|
||
|
|
||
| class ActorSerializer(serializers.ModelSerializer): | ||
|
|
||
| class Meta: | ||
| model = Actor | ||
| fields = ["id", "first_name", "last_name"] | ||
|
|
||
|
|
||
| class CinemaHallSerializer(serializers.ModelSerializer): | ||
|
|
||
| class Meta: | ||
| model = CinemaHall | ||
| fields = ["id", "name", "rows", "seats_in_row"] |
cinema/views.py
Outdated
Comment on lines
36
to
38
| class GenreDetail(APIView): | ||
| def get(self, request, pk): | ||
| genre = get_object_or_404(Genre, pk=pk) |
There was a problem hiding this comment.
You can create get_object method, It will be more readable.
cinema/views.py
Outdated
| if request.method == "PUT": | ||
| serializer = MovieSerializer(movie, data=request.data) | ||
| def put(self, request, pk): | ||
| genre = get_object_or_404(Genre, pk=pk) |
cinema/views.py
Outdated
|
|
||
| def patch(self, request, pk): | ||
| genre = get_object_or_404(Genre, pk=pk) |
|
I have just pushed that( |
Y-Havryliv
approved these changes
Nov 29, 2023
cinema/serializers.py
Outdated
|
|
||
| def update(self, instance, validated_data): | ||
| instance.title = validated_data.get("title", instance.title) | ||
| instance.description = validated_data.get( | ||
| "description", instance.description | ||
| ) | ||
| instance.duration = validated_data.get("duration", instance.duration) | ||
|
|
||
| actors_data = validated_data.pop("actors", "") |
There was a problem hiding this comment.
it's better to use an empty list instead of string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.