Solution #396
Open
Solution #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wQuelS
suggested changes
Nov 29, 2023
cinema/urls.py
Outdated
Comment on lines
12
to
19
| cinema_hall_list = CinemaHallViewSet.as_view(actions={"get": "list", | ||
| "post": "create"}) | ||
| cinema_hall_detail = CinemaHallViewSet.as_view( | ||
| actions={"get": "retrieve", | ||
| "put": "update", | ||
| "patch": "partial_update", | ||
| "delete": "destroy"} | ||
| ) |
There was a problem hiding this comment.
2 different ways of formatting is not really good. Choose one and use it everywhere. ( I prefer second one, but it is up to you )
cinema/urls.py
Outdated
| path("cinema_halls/<int:pk>/", | ||
| cinema_hall_detail, | ||
| name="cinema_hall-detail"), | ||
| path("", include(router.urls)) |
There was a problem hiding this comment.
it is not a reason for reject, but it is better to put a general path in the beginning
There was a problem hiding this comment.
tried path("/", include(router.urls)) but got some failed tests, so didn't add this to final commit
There was a problem hiding this comment.
i meant just to move path("", include(router.urls)) to the beginning:)
cinema/urls.py
Outdated
| path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"), | ||
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path("cinema_halls/", cinema_hall_list, name="cinema_hall-list"), |
There was a problem hiding this comment.
copy-paste type of issue 😁. fixed
cinema/views.py
Outdated
Comment on lines
11
to
12
| from rest_framework.views import APIView | ||
| from cinema.serializers import (MovieSerializer, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.