Develop #397
Open
Develop #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlehShumov
approved these changes
Nov 29, 2023
fsocie7y
suggested changes
Nov 29, 2023
| @@ -1,24 +1,104 @@ | |||
| from rest_framework import serializers | |||
|
|
|||
| from cinema.models import Movie | |||
| from cinema.models import Movie, Actor, CinemaHall, Genre | |||
|
|
|||
|
|
|||
| class MovieSerializer(serializers.Serializer): | |||
| id = serializers.IntegerField(read_only=True) | |||
| title = serializers.CharField(max_length=255) | |||
| description = serializers.CharField() | |||
There was a problem hiding this comment.
mb its better to use TextField if u dont specify max_length
There was a problem hiding this comment.
is TextField in serializers?
cinema/views.py
Outdated
Comment on lines
1
to
6
| from rest_framework.request import Request | ||
| from rest_framework.response import Response | ||
| from rest_framework import status | ||
| from rest_framework import status, mixins, generics, viewsets | ||
|
|
||
| from django.shortcuts import get_object_or_404 | ||
| from rest_framework.views import APIView |
There was a problem hiding this comment.
you need to follow the sequence of imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.