Solution #404
Closed
Solution #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wQuelS
suggested changes
Nov 29, 2023
cinema/urls.py
Outdated
| cinema_hall_detail, | ||
| name="cinemahall-detail", | ||
| ), | ||
| path("", include(router.urls)) |
There was a problem hiding this comment.
it is overall better to put such general path at the beginning
cinema/urls.py
Outdated
| path( | ||
| "cinema_halls/<int:pk>/", | ||
| cinema_hall_detail, | ||
| name="cinemahall-detail", |
There was a problem hiding this comment.
Yeah, you were trying to avoid -. But there is no such word as cinemahall. Try to come up with solution that will use cinema hall and also will not mix _ and -.
wQuelS
reviewed
Nov 29, 2023
| path("genres/", GenreList.as_view(), name="genre-list"), | ||
| path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"), | ||
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path( | ||
| "cinema_halls/", | ||
| cinema_hall_list, | ||
| name="cinemahall-list", | ||
| name="hall-list", |
There was a problem hiding this comment.
nice 😂😂
I meant something like cinema-hall. But let it be))
wQuelS
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.