Solution #405
Open
Solution #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wQuelS
suggested changes
Nov 29, 2023
cinema/serializers.py
Outdated
Comment on lines
11
to
18
| actors = serializers.PrimaryKeyRelatedField( | ||
| queryset=Actor.objects.all(), | ||
| many=True | ||
| ) | ||
| genres = serializers.PrimaryKeyRelatedField( | ||
| queryset=Genre.objects.all(), | ||
| many=True | ||
| ) |
There was a problem hiding this comment.
you were not supposed to do so in this task according to the description
cinema/serializers.py
Outdated
Comment on lines
55
to
70
| def create(self, validated_data): | ||
| return Actor.objects.create(**validated_data) | ||
|
|
||
| def update(self, instance, validated_data): | ||
| instance.first_name = validated_data.get( | ||
| "first_name", | ||
| instance.first_name | ||
| ) | ||
| instance.last_name = validated_data.get( | ||
| "last_name", | ||
| instance.last_name | ||
| ) | ||
|
|
||
| instance.save() | ||
|
|
||
| return instance |
There was a problem hiding this comment.
this code ( as well as similar code in the next serializers) will not be needed if you do everything according to the task description. Fix everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.