-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore API view sets #411
Open
Sel-Fisher
wants to merge
5
commits into
mate-academy:master
Choose a base branch
from
Sel-Fisher:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d3fa906
Explore API view sets
Sel-Fisher ebea25c
Hotfix required field and add patch methods to genres and actors views
Sel-Fisher 1486269
Fix requirements for serializers
Sel-Fisher 0efd119
Provide status to GenreDetail method get. Delete useless required=Tru…
Sel-Fisher dcea38e
Forgotten import
Sel-Fisher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ | |
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
initial = True | ||
|
||
dependencies = [] | ||
|
70 changes: 70 additions & 0 deletions
70
cinema/migrations/0002_actor_cinemahall_genre_movie_actors_movie_genres.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# Generated by Django 4.1 on 2023-11-29 23:08 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("cinema", "0001_initial"), | ||
] | ||
|
||
operations = [ | ||
migrations.CreateModel( | ||
name="Actor", | ||
fields=[ | ||
( | ||
"id", | ||
models.BigAutoField( | ||
auto_created=True, | ||
primary_key=True, | ||
serialize=False, | ||
verbose_name="ID", | ||
), | ||
), | ||
("first_name", models.CharField(max_length=255)), | ||
("last_name", models.CharField(max_length=255)), | ||
], | ||
), | ||
migrations.CreateModel( | ||
name="CinemaHall", | ||
fields=[ | ||
( | ||
"id", | ||
models.BigAutoField( | ||
auto_created=True, | ||
primary_key=True, | ||
serialize=False, | ||
verbose_name="ID", | ||
), | ||
), | ||
("name", models.CharField(max_length=255)), | ||
("rows", models.IntegerField()), | ||
("seats_in_row", models.IntegerField()), | ||
], | ||
), | ||
migrations.CreateModel( | ||
name="Genre", | ||
fields=[ | ||
( | ||
"id", | ||
models.BigAutoField( | ||
auto_created=True, | ||
primary_key=True, | ||
serialize=False, | ||
verbose_name="ID", | ||
), | ||
), | ||
("name", models.CharField(max_length=255, unique=True)), | ||
], | ||
), | ||
migrations.AddField( | ||
model_name="movie", | ||
name="actors", | ||
field=models.ManyToManyField(related_name="movies", to="cinema.actor"), | ||
), | ||
migrations.AddField( | ||
model_name="movie", | ||
name="genres", | ||
field=models.ManyToManyField(related_name="movies", to="cinema.genre"), | ||
), | ||
] |
26 changes: 26 additions & 0 deletions
26
cinema/migrations/0003_alter_movie_actors_alter_movie_genres.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# Generated by Django 4.1 on 2023-11-30 00:38 | ||
|
||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
dependencies = [ | ||
("cinema", "0002_actor_cinemahall_genre_movie_actors_movie_genres"), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name="movie", | ||
name="actors", | ||
field=models.ManyToManyField( | ||
blank=True, related_name="movies", to="cinema.actor" | ||
), | ||
), | ||
migrations.AlterField( | ||
model_name="movie", | ||
name="genres", | ||
field=models.ManyToManyField( | ||
blank=True, related_name="movies", to="cinema.genre" | ||
), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,87 @@ | ||
from rest_framework import serializers | ||
|
||
from cinema.models import Movie | ||
from cinema.models import Movie, Genre, Actor, CinemaHall | ||
|
||
|
||
class GenreSerializer(serializers.Serializer): | ||
id = serializers.IntegerField(read_only=True) | ||
name = serializers.CharField(max_length=255, required=True) | ||
|
||
def create(self, validated_data): | ||
return Genre.objects.create(**validated_data) | ||
|
||
def update(self, instance, validated_data): | ||
instance.name = validated_data.get("name", instance.name) | ||
instance.save() | ||
return instance | ||
|
||
|
||
class ActorSerializer(serializers.Serializer): | ||
id = serializers.IntegerField(read_only=True) | ||
first_name = serializers.CharField(max_length=255, required=True) | ||
last_name = serializers.CharField(max_length=255, required=True) | ||
|
||
def create(self, validated_data): | ||
return Actor.objects.create(**validated_data) | ||
|
||
def update(self, instance, validated_data): | ||
instance.first_name = validated_data.get( | ||
"first_name", instance.first_name | ||
) | ||
instance.last_name = validated_data.get( | ||
"last_name", instance.last_name | ||
) | ||
instance.save() | ||
return instance | ||
|
||
|
||
class CinemaHallSerializer(serializers.Serializer): | ||
id = serializers.IntegerField(read_only=True) | ||
name = serializers.CharField(max_length=255, required=True) | ||
rows = serializers.IntegerField(required=True) | ||
seats_in_row = serializers.IntegerField(required=True) | ||
|
||
def create(self, validated_data): | ||
return CinemaHall.objects.create(**validated_data) | ||
|
||
def update(self, instance, validated_data): | ||
instance.name = validated_data.get("name", instance.name) | ||
instance.rows = validated_data.get("rows", instance.rows) | ||
instance.seats_in_row = validated_data.get( | ||
"seats_in_row", instance.seats_in_row | ||
) | ||
instance.save() | ||
return instance | ||
|
||
|
||
class MovieSerializer(serializers.Serializer): | ||
id = serializers.IntegerField(read_only=True) | ||
title = serializers.CharField(max_length=255) | ||
description = serializers.CharField() | ||
duration = serializers.IntegerField() | ||
title = serializers.CharField(max_length=255, required=True) | ||
description = serializers.CharField(required=False) | ||
actors = ActorSerializer(many=True, required=False) | ||
genres = GenreSerializer(many=True, required=False) | ||
duration = serializers.IntegerField(required=True) | ||
|
||
def create(self, validated_data): | ||
return Movie.objects.create(**validated_data) | ||
actors_data = validated_data.pop("actors", []) | ||
genres_data = validated_data.pop("genres", []) | ||
movie = Movie.objects.create(**validated_data) | ||
movie.actors.set(actors_data) | ||
movie.genres.set(genres_data) | ||
|
||
return movie | ||
|
||
def update(self, instance, validated_data): | ||
instance.title = validated_data.get("title", instance.title) | ||
instance.description = validated_data.get( | ||
"description", instance.description | ||
) | ||
instance.duration = validated_data.get("duration", instance.duration) | ||
|
||
actors_data = validated_data.pop("actors", []) | ||
genres_data = validated_data.pop("genres", []) | ||
if actors_data: | ||
instance.actors.set(actors_data) | ||
if genres_data: | ||
instance.genres.set(genres_data) | ||
instance.save() | ||
|
||
return instance |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,42 @@ | ||
from django.urls import path | ||
from django.urls import path, include | ||
from rest_framework import routers | ||
|
||
from cinema.views import movie_list, movie_detail | ||
from cinema.views import ( | ||
GenreList, | ||
GenreDetail, | ||
ActorList, | ||
ActorDetail, | ||
CinemaHallViewSet, | ||
MovieViewSet, | ||
) | ||
|
||
cinema_hall_list = CinemaHallViewSet.as_view( | ||
actions={"get": "list", "post": "create"} | ||
) | ||
cinema_hall_detail = CinemaHallViewSet.as_view( | ||
{ | ||
"get": "retrieve", | ||
"put": "update", | ||
"patch": "partial_update", | ||
"delete": "destroy" | ||
} | ||
) | ||
|
||
router = routers.DefaultRouter() | ||
router.register("movies", MovieViewSet) | ||
|
||
urlpatterns = [ | ||
path("movies/", movie_list, name="movie-list"), | ||
path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
path("genres/", GenreList.as_view(), name="genre-list"), | ||
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"), | ||
path("cinema_halls/", cinema_hall_list, name="cinema-hall-list"), | ||
path( | ||
"cinema_halls/<int:pk>/", | ||
cinema_hall_detail, | ||
name="cinema-hall-detail" | ||
), | ||
path("actors/", ActorList.as_view(), name="actor-list"), | ||
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
path("", include(router.urls)), | ||
] | ||
|
||
app_name = "cinema" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required is True by default, fix everywhere please