Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #414

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Generated by Django 4.2.7 on 2023-11-29 16:49

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('cinema', '0001_initial'),
]

operations = [
migrations.CreateModel(
name='Actor',
fields=[
('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('first_name', models.CharField(max_length=255)),
('last_name', models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name='CinemaHall',
fields=[
('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255)),
('rows', models.IntegerField()),
('seats_in_row', models.IntegerField()),
],
),
migrations.CreateModel(
name='Genre',
fields=[
('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=63, unique=True)),
],
),
migrations.AddField(
model_name='movie',
name='actors',
field=models.ManyToManyField(to='cinema.actor'),
),
migrations.AddField(
model_name='movie',
name='genres',
field=models.ManyToManyField(to='cinema.genre'),
),
]
26 changes: 26 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,36 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=63, unique=True)

def __str__(self) -> str:
return self.name


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self) -> str:
return f"{self.first_name} {self.last_name}"


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.IntegerField()
seats_in_row = models.IntegerField()

def __str__(self) -> str:
return f"{self.name} {self.rows}x{self.seats_in_row}"


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
duration = models.IntegerField()
actors = models.ManyToManyField(Actor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's always a good idea to add related_name

genres = models.ManyToManyField(Genre)

def __str__(self):
return self.title
46 changes: 41 additions & 5 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,60 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Movie, Actor, Genre, CinemaHall


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()
actors = serializers.PrimaryKeyRelatedField(
queryset=Actor.objects.all(), required=False, many=True)
genres = serializers.PrimaryKeyRelatedField(
queryset=Genre.objects.all(), required=False, many=True)

def create(self, validated_data):
return Movie.objects.create(**validated_data)
actors_data = validated_data.pop("actors", [])
genres_data = validated_data.pop("genres", [])

movie = Movie.objects.create(**validated_data)

movie.actors.set(actors_data)
movie.genres.set(genres_data)

return movie

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get(
"description", instance.description
)
instance.duration = validated_data.get("duration", instance.duration)
instance.description = validated_data.get("description",
instance.description)
actors_data = validated_data.get("actors", [])
genres_data = validated_data.get("genres", [])

if actors_data:
instance.actors.set(actors_data)
if genres_data:
instance.genres.set(genres_data)

instance.save()

return instance


class ActorSerializer(serializers.ModelSerializer):
class Meta:
model = Actor
fields = "__all__"


class GenreSerializer(serializers.ModelSerializer):
class Meta:
model = Genre
fields = "__all__"


class CinemaHallSerializer(serializers.ModelSerializer):
class Meta:
model = CinemaHall
fields = "__all__"
37 changes: 33 additions & 4 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,39 @@
from django.urls import path
from django.urls import path, include
from rest_framework import routers

from cinema.views import movie_list, movie_detail
from cinema.views import (GenreList,
GenreDetail,
ActorList,
ActorDetail,
CinemaHallViewSet,
MovieViewSet
)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little mistake, u must write:

from cinema.views import (
GenreList,
...
MovieViewSet
)

or:

...import (GenreList,
...
MovieViewSet)

cinema_hall_list = CinemaHallViewSet.as_view(
actions={"get": "list",
"post": "create", }
)

cinema_hall_detail = CinemaHallViewSet.as_view(
actions={"get": "retrieve",
"put": "update",
"patch": "partial_update",
"delete": "destroy", }
)


router = routers.DefaultRouter()
router.register("movies", MovieViewSet)
urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
path("", include(router.urls)),
path("cinema_halls/", cinema_hall_list, name="cinema-hall-list"),
path("cinema_halls/<int:pk>/",
cinema_hall_detail,
name="cinema-hall-detail"),
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
]

app_name = "cinema"
125 changes: 102 additions & 23 deletions cinema/views.py
Original file line number Diff line number Diff line change
@@ -1,45 +1,124 @@
from rest_framework.decorators import api_view
from rest_framework.response import Response
from rest_framework import status
from rest_framework import status, mixins, viewsets, generics

from django.shortcuts import get_object_or_404
from rest_framework.views import APIView

from cinema.models import Movie
from cinema.serializers import MovieSerializer
from cinema.models import Movie, Genre, Actor, CinemaHall
from cinema.serializers import (MovieSerializer,
GenreSerializer,
ActorSerializer,
CinemaHallSerializer)


@api_view(["GET", "POST"])
def movie_list(request):
if request.method == "GET":
movies = Movie.objects.all()
serializer = MovieSerializer(movies, many=True)
return Response(serializer.data, status=status.HTTP_200_OK)
class GenreList(APIView):
def get(self, request) -> Response:
genres = Genre.objects.all()
serializer = GenreSerializer(genres, many=True)
return Response(serializer.data, status.HTTP_200_OK)

if request.method == "POST":
serializer = MovieSerializer(data=request.data)
def post(self, request) -> Response:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotate request as well, keep your project one-styled

serializer = GenreSerializer(data=request.data)
if serializer.is_valid():
serializer.save()
return Response(serializer.data, status=status.HTTP_201_CREATED)

return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)


@api_view(["GET", "PUT", "DELETE"])
def movie_detail(request, pk):
movie = get_object_or_404(Movie, pk=pk)
class GenreDetail(APIView):
def get_object(self, pk):
return get_object_or_404(Genre, pk=pk)

def get(self, request, pk):
current_genre = self.get_object(pk=pk)
serializer = GenreSerializer(current_genre)

return Response(data=serializer.data, status=status.HTTP_200_OK)

if request.method == "GET":
serializer = MovieSerializer(movie)
return Response(serializer.data, status=status.HTTP_200_OK)
def put(self, request, pk):
current_genre = self.get_object(pk)
serializer = GenreSerializer(current_genre, data=request.data)
if serializer.is_valid():
serializer.save()
return Response(
data=serializer.data,
status=status.HTTP_200_OK
)
return Response(
serializer.errors,
status=status.HTTP_400_BAD_REQUEST
)

if request.method == "PUT":
serializer = MovieSerializer(movie, data=request.data)
def patch(self, request, pk):
current_genre = self.get_object(pk)
serializer = GenreSerializer(
current_genre,
data=request.data,
partial=True
)
if serializer.is_valid():
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
return Response(data=serializer.data, status=status.HTTP_200_OK)

return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

if request.method == "DELETE":
movie.delete()
def delete(self, request, pk):
genre = self.get_object(pk)
genre.delete()

return Response(status=status.HTTP_204_NO_CONTENT)


class ActorList(
mixins.ListModelMixin,
mixins.CreateModelMixin,
generics.GenericAPIView
):
queryset = Actor.objects.all()
serializer_class = ActorSerializer

def get(self, request, *args, **kwargs):
return self.list(request, *args, **kwargs)

def post(self, request, *args, **kwargs):
return self.create(request, *args, **kwargs)


class ActorDetail(
mixins.DestroyModelMixin,
mixins.UpdateModelMixin,
mixins.RetrieveModelMixin,
generics.GenericAPIView
):
queryset = Actor.objects.all()
serializer_class = ActorSerializer

def get(self, request, *args, **kwargs):
return self.retrieve(request, *args, **kwargs)

def put(self, request, *args, **kwargs):
return self.update(request, *args, **kwargs)

def patch(self, request, *args, **kwargs):
return self.partial_update(request, *args, **kwargs)

def delete(self, request, *args, **kwargs):
return self.destroy(request, *args, **kwargs)


class CinemaHallViewSet(
mixins.ListModelMixin,
mixins.CreateModelMixin,
mixins.RetrieveModelMixin,
mixins.UpdateModelMixin,
mixins.DestroyModelMixin,
viewsets.GenericViewSet
):
queryset = CinemaHall.objects.all()
serializer_class = CinemaHallSerializer


class MovieViewSet(viewsets.ModelViewSet):
queryset = Movie.objects.all()
serializer_class = MovieSerializer
Loading