implement py-api-views #674
Conversation
cinema/serializers.py
Outdated
| title = serializers.CharField(max_length=255) | ||
| description = serializers.CharField() | ||
| duration = serializers.IntegerField() | ||
| name = serializers.CharField(max_length=255) |
There was a problem hiding this comment.
Do you need to define these fields if you use ModelSerializer?
db.sqlite3
Outdated
There was a problem hiding this comment.
You don't need to push this file.
There was a problem hiding this comment.
You stille have this file here.
cinema/serializers.py
Outdated
|
|
||
|
|
||
| class MovieSerializer(serializers.Serializer): | ||
| class MovieSerializer(serializers.ModelSerializer): | ||
| actors = serializers.PrimaryKeyRelatedField( |
There was a problem hiding this comment.
Using PrimaryKeyRelatedField you will have N+1 query problem.
cinema/views.py
Outdated
|
|
||
| class MovieViewSet(viewsets.ModelViewSet): | ||
| queryset = Movie.objects.all() |
There was a problem hiding this comment.
Using PrimaryKeyRelatedField in your serializer you will have N+1 query problem for genres and actors.
There was a problem hiding this comment.
Use prefetch_related to solve N+1 problem.
cinema/views.py
Outdated
|
|
||
| class GenreList(APIView): | ||
| def get(self, request: HttpRequest) -> Response: | ||
| genre = Genre.objects.all() |
There was a problem hiding this comment.
name it in plural - genres
cinema/urls.py
Outdated
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path("genres/", GenreList.as_view(), name="actor-list"), | ||
| path("genres/<int:pk>/", GenreDetail.as_view(), name="actor-detail"), | ||
| path( |
There was a problem hiding this comment.
You can register CinemaHallViewSet in router with the correct prefix. It will look better
cinema/urls.py
Outdated
| GenreList, | ||
| CinemaHallViewSet | ||
| ) | ||
| from .views import MovieViewSet |
There was a problem hiding this comment.
Add this to the import above
cinema/urls.py
Outdated
| path("", include(router.urls)), | ||
| path("actors/", ActorList.as_view(), name="actor-list"), | ||
| path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"), | ||
| path("genres/", GenreList.as_view(), name="actor-list"), |
There was a problem hiding this comment.
the name here should be "genre-list". See also below.
| description = serializers.CharField() | ||
| duration = serializers.IntegerField() | ||
| class MovieSerializer(serializers.ModelSerializer): | ||
| genres = serializers.SerializerMethodField() |
There was a problem hiding this comment.
Not necessary in this task
Create serializers for all these models. Do not use related serializers for ManyToMany relations.
No description provided.