Solution #675
Open
Solution #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maksym-Turenko
approved these changes
Sep 28, 2024
oliasymak24
suggested changes
Sep 30, 2024
cinema/models.py
Outdated
| @@ -1,10 +1,36 @@ | |||
| from django.db import models | |||
|
|
|||
|
|
|||
| class Actor(models.Model): | |||
| first_name = models.CharField(max_length=50) | |||
There was a problem hiding this comment.
suggest you choose value 2^n - 1 for max_length
cinema/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| path("movies/", movie_list, name="movie-list"), | ||
| path("movies/<int:pk>/", movie_detail, name="movie-detail"), | ||
|
|
cinema/views.py
Outdated
|
|
||
| from django.shortcuts import get_object_or_404 | ||
| from rest_framework.views import APIView |
There was a problem hiding this comment.
Put this import to other rest_framework imports
cinema/views.py
Outdated
| movies = Movie.objects.all() | ||
| serializer = MovieSerializer(movies, many=True) | ||
| class GenreList(APIView): | ||
| def get(self, request) -> Response: |
There was a problem hiding this comment.
Fix the annotation for request, check everywhere
Arsen-hrynevych
approved these changes
Oct 8, 2024
Comment on lines
+83
to
+93
| def get(self, request, *args, **kwargs) -> Response: | ||
| return self.retrieve(request, *args, **kwargs) | ||
|
|
||
| def put(self, request, *args, **kwargs) -> Response: | ||
| return self.update(request, *args, **kwargs) | ||
|
|
||
| def patch(self, request, *args, **kwargs) -> Response: | ||
| return self.partial_update(request, *args, **kwargs) | ||
|
|
||
| def delete(self, request, *args, **kwargs) -> Response: | ||
| return self.destroy(request, *args, **kwargs) |
There was a problem hiding this comment.
These methods have already been defined inside your classes
Comment on lines
+67
to
+71
| def get(self, request, *args, **kwargs) -> Response: | ||
| return self.list(request, *args, **kwargs) | ||
|
|
||
| def post(self, request, *args, **kwargs) -> Response: | ||
| return self.create(request, *args, **kwargs) |
There was a problem hiding this comment.
These methods have already been defined inside your classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.