Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #706

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #706

wants to merge 5 commits into from

Conversation

Viesich
Copy link

@Viesich Viesich commented Oct 20, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 While there's a minor issue with duplicate paths for 'actors/', it doesn't impact the core functionality. Keep up the good work and consider cleaning up the redundancy in future updates!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

cinema/urls.py Outdated
name="genre-delete"
),
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/", ActorList.as_view(), name="actor-list"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there is a duplicate path for 'actors/'. You have two identical paths with the same name 'actor-list'. Consider removing one of them to avoid redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants