Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions cinema/models.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,45 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self) -> str:
return self.name


class Actor(models.Model):
first_name = models.CharField(max_length=255)
last_name = models.CharField(max_length=255)

def __str__(self) -> str:
return f"{self.first_name} {self.last_name}"


class Movie(models.Model):
title = models.CharField(max_length=255)
description = models.TextField()
duration = models.IntegerField()
actors = models.ManyToManyField(to=Actor, related_name="movies")
genre = models.ManyToManyField(to=Genre, related_name="movies")

class Meta:
indexes = [
models.Index(fields=["title"]),
]

def __str__(self):
return self.title


class CinemaHall(models.Model):
name = models.CharField(max_length=255)
rows = models.IntegerField()
seats_in_row = models.ImageField()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The seats_in_row field is incorrectly defined as an ImageField. It should be an IntegerField to represent the number of seats in each row. This is crucial for correctly calculating the capacity property.


@property
def capacity(self) -> int:
return self.rows * self.seats_in_row

def __str__(self) -> str:
return self.name
44 changes: 28 additions & 16 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,36 @@
from rest_framework import serializers

from cinema.models import Movie
from cinema.models import Movie, Actor, Genre, CinemaHall


class MovieSerializer(serializers.Serializer):
id = serializers.IntegerField(read_only=True)
title = serializers.CharField(max_length=255)
description = serializers.CharField()
duration = serializers.IntegerField()
class ActorSerializer(serializers.ModelSerializer):
class Meta:
model = Actor
fields = "__all__"

def create(self, validated_data):
return Movie.objects.create(**validated_data)

def update(self, instance, validated_data):
instance.title = validated_data.get("title", instance.title)
instance.description = validated_data.get(
"description", instance.description
)
instance.duration = validated_data.get("duration", instance.duration)
class GenreSerializer(serializers.ModelSerializer):
class Meta:
model = Genre
fields = "__all__"

instance.save()

return instance
class MovieSerializer(serializers.ModelSerializer):
actors = serializers.PrimaryKeyRelatedField(
many=True,
queryset=Actor.objects.all()
)
genres = serializers.PrimaryKeyRelatedField(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field name genres in MovieSerializer should be genre to match the field name in the Movie model. This ensures consistency and prevents potential errors when serializing and deserializing data.

many=True,
queryset=Genre.objects.all()
)
Comment on lines +23 to +26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field name genres should be changed to genre to match the field name in the Movie model. This ensures consistency and prevents potential errors during serialization and deserialization.


class Meta:
model = Movie
fields = "__all__"


class CinemaHallSerializer(serializers.ModelSerializer):
class Meta:
model = CinemaHall
fields = "__all__"
46 changes: 42 additions & 4 deletions cinema/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,48 @@
from django.urls import path
from django.urls import path, include
from rest_framework import routers

from cinema.views import movie_list, movie_detail

from cinema.views import (
CinemaHallViewSet,
ActorList,
ActorDetail,
GenreList,
GenreDetail,
MovieViewSet
)


cinema_hall_list = CinemaHallViewSet.as_view(
actions={
"get": "list",
"post": "create"
}
)

cinema_hall_detail = CinemaHallViewSet.as_view(
actions={
"get": "retrieve",
"put": "update",
"patch": "partial_update",
"delete": "destroy"
}
)

router = routers.DefaultRouter()

router.register(prefix="movies", viewset=MovieViewSet)
urlpatterns = [
path("movies/", movie_list, name="movie-list"),
path("movies/<int:pk>/", movie_detail, name="movie-detail"),
path("genres/", GenreList.as_view(), name="genre-list"),
path("genres/<int:pk>/", GenreDetail.as_view(), name="genre-detail"),
path("actors/", ActorList.as_view(), name="actor-list"),
path("actors/<int:pk>/", ActorDetail.as_view(), name="actor-detail"),
path("cinema_halls/", cinema_hall_list, name="cinema_hall-list"),
path(
"cinema_halls/<int:pk>/",
cinema_hall_detail,
name="cinema_hall-detail"
),
path("", include(router.urls)),
]

app_name = "cinema"
125 changes: 96 additions & 29 deletions cinema/views.py
Original file line number Diff line number Diff line change
@@ -1,45 +1,112 @@
from rest_framework.decorators import api_view
from rest_framework.response import Response
from rest_framework import status
from rest_framework.views import APIView
from rest_framework import generics, mixins
from rest_framework import viewsets

from django.shortcuts import get_object_or_404

from cinema.models import Movie
from cinema.serializers import MovieSerializer
from cinema.models import Movie, Actor, Genre, CinemaHall
from cinema.serializers import (
GenreSerializer,
ActorSerializer,
CinemaHallSerializer,
MovieSerializer
)


@api_view(["GET", "POST"])
def movie_list(request):
if request.method == "GET":
movies = Movie.objects.all()
serializer = MovieSerializer(movies, many=True)
return Response(serializer.data, status=status.HTTP_200_OK)
class GenreList(APIView):
def get(self, request) -> Response:
genres = Genre.objects.all()
serializer = GenreSerializer(genres, many=True)
return Response(serializer.data)

if request.method == "POST":
serializer = MovieSerializer(data=request.data)
if serializer.is_valid():
serializer.save()
return Response(serializer.data, status=status.HTTP_201_CREATED)
def post(self, request) -> Response:
serializer = GenreSerializer(data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data, status=status.HTTP_201_CREATED)

return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

class GenreDetail(APIView):
def get_object(self, pk):
return get_object_or_404(Genre, pk=pk)

@api_view(["GET", "PUT", "DELETE"])
def movie_detail(request, pk):
movie = get_object_or_404(Movie, pk=pk)
def get(self, request, pk) -> Response:
genre = self.get_object(pk)
serializer = GenreSerializer(genre)
return Response(serializer.data)

if request.method == "GET":
serializer = MovieSerializer(movie)
return Response(serializer.data, status=status.HTTP_200_OK)
def put(self, request, pk) -> Response:
genre = self.get_object(pk)
serializer = GenreSerializer(genre, data=request.data)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data)

if request.method == "PUT":
serializer = MovieSerializer(movie, data=request.data)
if serializer.is_valid():
serializer.save()
return Response(serializer.data, status=status.HTTP_200_OK)
def patch(self, request, pk) -> Response:
genre = self.get_object(pk)
serializer = GenreSerializer(genre, data=request.data, partial=True)
serializer.is_valid(raise_exception=True)
serializer.save()
return Response(serializer.data)

return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)

if request.method == "DELETE":
movie.delete()
def delete(self, request, pk) -> Response:
genre = self.get_object(pk)
genre.delete()
return Response(status=status.HTTP_204_NO_CONTENT)


class ActorList(
generics.GenericAPIView,
mixins.ListModelMixin,
mixins.CreateModelMixin
):
queryset = Actor.objects.all()
serializer_class = ActorSerializer

def get(self, request, *args, **kwargs) -> Response:
return self.list(request, *args, **kwargs)

def post(self, request, *args, **kwargs) -> Response:
return self.create(request, *args, **kwargs)


class ActorDetail(
generics.GenericAPIView,
mixins.RetrieveModelMixin,
mixins.UpdateModelMixin,
mixins.DestroyModelMixin
):
queryset = Actor.objects.all()
serializer_class = ActorSerializer

def get(self, request, *args, **kwargs) -> Response:
return self.retrieve(request, *args, **kwargs)

def put(self, request, *args, **kwargs) -> Response:
return self.update(request, *args, **kwargs)

def patch(self, request, *args, **kwargs) -> Response:
return self.partial_update(request, *args, **kwargs)

def delete(self, request, *args, **kwargs) -> Response:
return self.destroy(request, *args, **kwargs)


class CinemaHallViewSet(
viewsets.GenericViewSet,
mixins.ListModelMixin,
mixins.CreateModelMixin,
mixins.RetrieveModelMixin,
mixins.UpdateModelMixin,
mixins.DestroyModelMixin
):
queryset = CinemaHall.objects.all()
serializer_class = CinemaHallSerializer


class MovieViewSet(viewsets.ModelViewSet):
queryset = Movie.objects.all()
serializer_class = MovieSerializer
Loading