Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #726

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #726

wants to merge 5 commits into from

Conversation

Lev2098
Copy link

@Lev2098 Lev2098 commented Nov 26, 2024

No description provided.

…ed views:

-For the Genre model use an APIView
-For the Actor model use a GenericAPIView
-For the CinemaHall model use a GenericViewSet
-For the Movie model use a ModelViewSet and routers
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the models, views, and URL configurations! 🎉 The code is well-structured and follows Django conventions. Just a small note: consider switching to serializers.ModelSerializer if you need to use the Meta class in your serializers. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +18 to +20
class Meta:
model = Genre
fields = ("id", "name")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Meta class is not applicable for serializers.Serializer. Consider using serializers.ModelSerializer if you want to specify the model and fields.

Comment on lines +41 to +43
class Meta:
model = Actor
fields = ("id", "first_name", "last_name")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Meta class is not applicable for serializers.Serializer. Consider using serializers.ModelSerializer if you want to specify the model and fields.

Comment on lines +71 to +73
class Meta:
model = CinemaHall
fields = ("id", "name", "rows", "seats_in_row")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Meta class is not applicable for serializers.Serializer. Consider using serializers.ModelSerializer if you want to specify the model and fields.

Comment on lines +102 to +104
class Meta:
model = Movie
fields = ("id", "title", "description", "duration")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Meta class is not applicable for serializers.Serializer. Consider using serializers.ModelSerializer if you want to specify the model and fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants