-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #726
base: master
Are you sure you want to change the base?
Develop #726
Conversation
…ed views: -For the Genre model use an APIView -For the Actor model use a GenericAPIView -For the CinemaHall model use a GenericViewSet -For the Movie model use a ModelViewSet and routers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the models, views, and URL configurations! 🎉 The code is well-structured and follows Django conventions. Just a small note: consider switching to serializers.ModelSerializer
if you need to use the Meta
class in your serializers. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
class Meta: | ||
model = Genre | ||
fields = ("id", "name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Meta
class is not applicable for serializers.Serializer
. Consider using serializers.ModelSerializer
if you want to specify the model and fields.
class Meta: | ||
model = Actor | ||
fields = ("id", "first_name", "last_name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Meta
class is not applicable for serializers.Serializer
. Consider using serializers.ModelSerializer
if you want to specify the model and fields.
class Meta: | ||
model = CinemaHall | ||
fields = ("id", "name", "rows", "seats_in_row") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Meta
class is not applicable for serializers.Serializer
. Consider using serializers.ModelSerializer
if you want to specify the model and fields.
class Meta: | ||
model = Movie | ||
fields = ("id", "title", "description", "duration") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Meta
class is not applicable for serializers.Serializer
. Consider using serializers.ModelSerializer
if you want to specify the model and fields.
No description provided.