Solution #748
Open
Solution #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Great job! 🎉 Your implementation aligns well with the task requirements and follows Django and Django REST Framework conventions. Everything from models to views and serializers is set up correctly, and there are no critical issues affecting functionality. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
AnyoneClown
approved these changes
Dec 11, 2024
cinema/serializers.py
Outdated
Comment on lines
54
to
57
| instance.first_name = validated_data.get( | ||
| "first_name", instance.first_name) | ||
| instance.last_name = validated_data.get( | ||
| "last_name", instance.last_name) |
There was a problem hiding this comment.
Fix indentation.
Suggested change
| instance.first_name = validated_data.get( | |
| "first_name", instance.first_name) | |
| instance.last_name = validated_data.get( | |
| "last_name", instance.last_name) | |
| instance.first_name = validated_data.get( | |
| "first_name", instance.first_name | |
| ) | |
| instance.last_name = validated_data.get( | |
| "last_name", instance.last_name | |
| ) |
cinema/serializers.py
Outdated
Comment on lines
75
to
77
| instance.seats_in_row = validated_data.get( | ||
| "seats_in_row", instance.seats_in_row) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.