Solution #766
Open
Solution #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattalli
suggested changes
Dec 16, 2024
cinema/views.py
Outdated
Comment on lines
30
to
32
| if serializer.is_valid(): | ||
| serializer.save() | ||
| return Response(serializer.data, status=status.HTTP_201_CREATED) |
There was a problem hiding this comment.
use serializer.is_valid(raise_exception=True)
cinema/views.py
Outdated
Comment on lines
38
to
41
| try: | ||
| return Genre.objects.get(pk=pk) | ||
| except Genre.DoesNotExist: | ||
| raise Http404 |
There was a problem hiding this comment.
use get_object_or_404(Genre, pk=pk)
Arsen-hrynevych
suggested changes
Jan 10, 2025
There was a problem hiding this comment.
Imports should be grouped and separated by a blank line according to standard library, external libraries, and custom imports. This practice enhances both code readability and maintainability.
Read more about topic here
The views violate the DRY principle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.