Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't know what type to write owner, obj, objtype - errors flake8 #301

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 52 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,70 @@


class IntegerRange:
pass
def __init__(self, min_amount: int, max_amount: int) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __set_name__(self, owner, name: str) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __set_name__(self, owner, name: str) -> None:
def __set_name__(self, owner: Any, name: str) -> None:

self.public_name = name
self.protected_name = "_" + name

def __get__(self, obj, objtype=None) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __get__(self, obj, objtype=None) -> int:
def __get__(self, obj: Any, objtype=None) -> int:

value = getattr(obj, self.protected_name)
print(f"Accessing {self.public_name} giving {value}")
return value

def __set__(self, obj, value: int) -> bool:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __set__(self, obj, value: int) -> bool:
def __set__(self, obj: Any, value: int) -> bool:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую !

if value < self.min_amount or value > self.max_amount:
raise ValueError("Not acces")
setattr(obj, self.protected_name, value)


class Visitor:
pass
def __init__(self, name: str, age: int, weight: int, height: int) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
def __init__(self, age: int, weight: int, height: int) -> None:
self.age = age
self.weight = weight
self.height = height


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
weight = IntegerRange(20, 50)
height = IntegerRange(80, 120)

def __init__(self, age: int, weight: int, height: int) -> None:
super().__init__(age, weight, height)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
weight = IntegerRange(50, 120)
height = IntegerRange(120, 220)

def __init__(self, age: int, weight: int, height: int) -> None:
super().__init__(age, weight, height)


class Slide:
pass
def __init__(self,
name: str,
limitation_class: SlideLimitationValidator
) -> None:
self.name = name
self.limitation_class = limitation_class

def can_access(self, visitor: Visitor) -> bool:
try:
self.limitation_class(visitor.age, visitor.weight, visitor.height)
except ValueError:
return False

return True
Loading