Solution #333
Open
Solution #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasylhnatiuk
suggested changes
Oct 31, 2023
app/main.py
Outdated
| self.name = name | ||
| self.limitation_class = limitation_class | ||
|
|
||
| def can_access(self, visitor: Visitor) -> bool | str: |
There was a problem hiding this comment.
Suggested change
| def can_access(self, visitor: Visitor) -> bool | str: | |
| def can_access(self, visitor: Visitor) -> bool: |
app/main.py
Outdated
|
|
||
|
|
||
| class Slide: | ||
| pass | ||
|
|
||
| def __init__(self, name: str, limitation_class: Type) -> None: |
There was a problem hiding this comment.
Suggested change
| def __init__(self, name: str, limitation_class: Type) -> None: | |
| def __init__(self, name: str, limitation_class: SlideLimitationValidator) -> None: |
|
when I use this code this one works without such problem: |
ArsenPidhoretskyi
suggested changes
Nov 1, 2023
app/main.py
Outdated
Comment on lines
62
to
63
| else: | ||
| return True |
There was a problem hiding this comment.
Suggested change
| else: | |
| return True | |
| return True |
There was a problem hiding this comment.
else: is redundant in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.