Solution #350
Open
Solution #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktoria-rybenchuk
suggested changes
Nov 15, 2023
Comment on lines
+17
to
+18
| if self.min_amount <= value <= self.max_amount: | ||
| setattr(obj, self.protected_name, value) |
There was a problem hiding this comment.
raise ValueError when get incorrect value and add descriptive error message
app/main.py
Outdated
Comment on lines
41
to
44
| def validate(self) -> bool: | ||
| return (4 <= self.age <= 14 | ||
| and 80 <= self.height <= 120 | ||
| and 20 <= self.weight <= 50) |
There was a problem hiding this comment.
you should make validation by using IntegerRange
app/main.py
Outdated
Comment on lines
48
to
51
| def validate(self) -> bool: | ||
| return (14 <= self.age <= 60 | ||
| and 120 <= self.height <= 220 | ||
| and 50 <= self.weight <= 120) |
Dimosphen1
approved these changes
Nov 16, 2023
Comment on lines
+64
to
+68
| if self.limitation_class( | ||
| age=visitor.age, | ||
| height=visitor.height, | ||
| weight=visitor.weight | ||
| ): |
There was a problem hiding this comment.
There is no need to create an if condition, you could just make an initialization of a limitation_class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.