-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #651
base: master
Are you sure you want to change the base?
Solution #651
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,79 @@ | |
|
||
|
||
class IntegerRange: | ||
pass | ||
def __init__(self, min_amount: int, max_amount: int) -> None: | ||
self.min_amount = min_amount | ||
self.max_amount = max_amount | ||
|
||
def __set_name__(self, owner: type, name: str) -> None: | ||
self.protected_name = "_" + name | ||
|
||
def __get__(self, instance: type, owner: type) -> int: | ||
if instance is None: | ||
return self | ||
return getattr(instance, self.protected_name) | ||
|
||
def __set__(self, instance: type, value: int) -> int: | ||
if not isinstance(value, int): | ||
raise TypeError | ||
if not (self.min_amount <= value <= self.max_amount): | ||
raise ValueError | ||
setattr(instance, self.protected_name, value) | ||
|
||
|
||
class Visitor: | ||
pass | ||
age = IntegerRange(0, 120) | ||
weight = IntegerRange(0, 300) | ||
height = IntegerRange(50, 250) | ||
|
||
def __init__(self, name: str, age: int, weight: int, height: int) -> None: | ||
self.name = name | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class SlideLimitationValidator(ABC): | ||
pass | ||
def __init__(self, age: int, height: int, weight: int) -> None: | ||
self.age = age | ||
self.weight = weight | ||
self.height = height | ||
|
||
|
||
class ChildrenSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(4, 14) | ||
height = IntegerRange(80, 120) | ||
weight = IntegerRange(20, 50) | ||
|
||
def __init__(self, age: int, height: int, weight: int) -> None: | ||
self.age = age | ||
self.height = height | ||
self.weight = weight | ||
|
||
|
||
class AdultSlideLimitationValidator(SlideLimitationValidator): | ||
pass | ||
age = IntegerRange(14, 60) | ||
height = IntegerRange(120, 220) | ||
weight = IntegerRange(50, 120) | ||
|
||
def __init__(self, age: int, height: int, weight: int) -> None: | ||
self.age = age | ||
self.height = height | ||
self.weight = weight | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the |
||
|
||
|
||
class Slide: | ||
pass | ||
def __init__(self, name: str, limitation_class: type) -> None: | ||
self.name = name | ||
self.limitation_class = limitation_class | ||
|
||
def can_access(self, visitor: Visitor) -> bool: | ||
try: | ||
self.limitation_class( | ||
age=visitor.age, | ||
height=visitor.height, | ||
weight=visitor.weight, | ||
) | ||
return True | ||
except (ValueError, TypeError): | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ChildrenSlideLimitationValidator
class overrides the__init__
method but does not call the superclassSlideLimitationValidator
's__init__
method. This can lead to incorrect initialization of the parent class attributes. Consider usingsuper().__init__(age, height, weight)
to ensure proper initialization.