Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #652

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 112 additions & 6 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,131 @@
from abc import ABC
from typing import Any


class IntegerRange:
pass
def __init__(
self,
min_amount: int,
max_amount: int
) -> None:
self.min_amount = min_amount
self.max_amount = max_amount

def __get__(
self,
obj: Any,
objtype: None | Any = None
) -> int | str:
if obj is None:
return self

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mistake here. The __get__ method should return the value of the attribute, not self. Returning self is incorrect and will lead to unexpected behavior when accessing the attribute.

value = getattr(obj, self.private_name, None)
return value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __get__ method should return the actual value of the attribute, not self. Returning self will cause unexpected behavior when accessing the attribute. You should return the value variable instead.


def __set__(
self,
obj: Any,
value: int
) -> None:
if not isinstance(value, int):
raise TypeError(f"{value} must be an integer")
if not (self.min_amount <= value <= self.max_amount):
raise ValueError(
f"{value} must be between "
f"{self.min_amount} and {self.max_amount}"
)
setattr(obj, self.private_name, value)

def __set_name__(
self,
owner: Any,
name: str
) -> None:
self.public_name = name
self.private_name = "_" + name


class Visitor:
pass
def __init__(
self,
name: str,
age: int,
weight: int,
height: int
) -> None:
self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):
pass
age = IntegerRange(4, 60)
weight = IntegerRange(20, 120)
height = IntegerRange(80, 120)

def __init__(
self,
age: int,
height: int,
weight: int
) -> None:
self.age = age
self.height = height
self.weight = weight


class ChildrenSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(4, 14)
weight = IntegerRange(20, 50)
height = IntegerRange(80, 120)

def __init__(
self,
name: str,
age: int,
height: int,
weight: int
) -> None:
self.name = name
super().__init__(age, height, weight)


class AdultSlideLimitationValidator(SlideLimitationValidator):
pass
age = IntegerRange(14, 60)
weight = IntegerRange(50, 120)
height = IntegerRange(120, 220)

def __init__(
self,
name: str,
age: int,
height: int,
weight: int
) -> None:
self.name = name
super().__init__(age, height, weight)


class Slide:
pass
def __init__(
self,
name: str,
limitation_class: Any
) -> None:
self.name = name
self.limitation_class = limitation_class

def can_access(
self,
visitor: Any
) -> bool:
try:
self.limitation_class(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limitation_class is expected to be a class, not an instance. You should instantiate it here with the visitor's attributes to check the constraints. Consider using self.limitation_class(visitor.age, visitor.height, visitor.weight) instead.

self.name,
age=visitor.age,
height=visitor.height,
weight=visitor.weight
)
return True
except ValueError:
return False
Loading