Develop #653
Develop #653
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this pull request! 😊 While your code meets most of the task requirements, there are a couple of critical issues that need to be addressed before we can approve it:
-
Incorrect Tuple Usage in Validator Classes: In both
ChildrenSlideLimitationValidatorandAdultSlideLimitationValidator, the attributesage,weight, andheightare mistakenly defined as tuples because of trailing commas. This needs to be corrected by removing the commas to ensure they are instances ofIntegerRange. -
Incorrect Range Values: The
ChildrenSlideLimitationValidatorclass has incorrect range values forweightandheight. Please update theweightto be in the range of20to50, and theheightto be in the range of80to120as per the task requirements.
Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you have any questions or need further assistance. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| age = IntegerRange(4, 14), | ||
| weight = IntegerRange(80, 120), | ||
| height = IntegerRange(20, 50) |
There was a problem hiding this comment.
The class attributes age, weight, and height in ChildrenSlideLimitationValidator are incorrectly defined as tuples due to the trailing commas. Remove the commas to correctly define them as instances of IntegerRange.
app/main.py
Outdated
| age = IntegerRange(14, 60), | ||
| weight = IntegerRange(120, 220), | ||
| height = IntegerRange(50, 120) |
There was a problem hiding this comment.
Similar to the ChildrenSlideLimitationValidator, the class attributes age, weight, and height in AdultSlideLimitationValidator are incorrectly defined as tuples. Remove the trailing commas to define them correctly as IntegerRange instances.
No description provided.