Aquapark validation done #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L1nk3rrr
suggested changes
Dec 16, 2024
app/main.py
Outdated
| if not isinstance(value, int): | ||
| raise TypeError(f"Expected an int, got {type(value)}") | ||
|
|
||
| if value not in range(self.min_amount, self.max_amount + 1): |
There was a problem hiding this comment.
using range can be a heavy op, use a < b < c construction
app/main.py
Outdated
| @@ -1,25 +1,98 @@ | |||
| from abc import ABC | |||
| from typing import Type, Any | |||
There was a problem hiding this comment.
You don't need to import Type, use from future import annotations
…s are necessary. Removed them, and used just SlideLimitationValidator in type hint for Slide class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.