Develop #674
Draft
Develop #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 While there are some minor issues regarding the use of float instead of int in the Visitor class and the IntegerRange descriptor, these do not critically impact the functionality. Consider refining these aspects to better align with the intended use of integer constraints. Keep up the good work and continue improving your code! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
app/main.py
Outdated
Comment on lines
31
to
33
| age: float, | ||
| weight: float, | ||
| height: float |
There was a problem hiding this comment.
The Visitor class uses float for age, weight, and height. If the intention is to use IntegerRange, these should be int to match the descriptor's purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.