Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution - aquapark #678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution - aquapark #678

wants to merge 1 commit into from

Conversation

YBlck
Copy link

@YBlck YBlck commented Jan 16, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the solution! 🎉 The code meets the task requirements and constraints effectively. While there are a couple of suggestions for improvement, such as explicitly typing the limitation_class parameter and marking SlideLimitationValidator as abstract, these are minor and don't impact the core functionality. Keep up the great work and consider these enhancements for future projects! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

self.name = name
self.age = age
self.weight = weight
self.height = height


class SlideLimitationValidator(ABC):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SlideLimitationValidator class should be marked as abstract by including at least one abstract method. Consider adding an abstract method to enforce that subclasses implement specific behavior.



class Slide:
pass
def __init__(self, name: str, limitation_class: Type) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limitation_class parameter should be explicitly typed to ensure it is a subclass of SlideLimitationValidator. Consider using Type[SlideLimitationValidator] to enforce this constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants