Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement async code #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement async code #483

wants to merge 1 commit into from

Conversation

Mxbely
Copy link

@Mxbely Mxbely commented Jan 9, 2025

image

Copy link

@YaroslavBordovoy YaroslavBordovoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's what the console output should be in the end. Plus we were given 2 extra functions to use, plus the hint said to remove wake_up_program, sleep_program and run the programs block

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing asynchronous operations using asyncio! 🎉 Your code meets the task requirements and constraints effectively. The only suggestion is to consider using run_sequence and run_parallel helper functions in main.py to ensure the logical order of operations, as this will prevent potential logical errors. Keep up the excellent work and continue refining your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants