'Solution' #309
Open
'Solution' #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Oct 6, 2023
app/main.py
Outdated
| self.is_drowned = is_drowned | ||
| self.decks = Ship.create_decks(start, end) | ||
|
|
||
| def get_deck(self, row: int, column: int) -> Deck: |
app/main.py
Outdated
Comment on lines
33
to
36
| self.is_drowned = True | ||
| for deck in self.decks: | ||
| if deck.is_alive: | ||
| self.is_drowned = False |
app/main.py
Outdated
Comment on lines
44
to
56
| if ship_begin == ship_end: | ||
| return [Deck(*ship_begin)] | ||
|
|
||
| def fire(self, row, column): | ||
| # Change the `is_alive` status of the deck | ||
| # And update the `is_drowned` value if it's needed | ||
| pass | ||
| border = 0 | ||
| if ship_begin[1] != ship_end[1]: | ||
| border = 1 | ||
|
|
||
| ship_decks = [Deck(ship_begin[0], ship_begin[1])] | ||
| blank_deck = [ship_begin[0], ship_begin[1]] | ||
|
|
||
| while blank_deck[border] != ship_end[border]: | ||
| blank_deck[border] += 1 | ||
| ship_decks.append(Deck(blank_deck[0], blank_deck[1])) |
There was a problem hiding this comment.
Instead of if+ while just use forloop into forloop
app/main.py
Outdated
Comment on lines
76
to
77
| else: | ||
| return "Miss!" |
There was a problem hiding this comment.
Suggested change
| else: | |
| return "Miss!" | |
| return "Miss!" |
ArsenPidhoretskyi
suggested changes
Oct 9, 2023
app/main.py
Outdated
| self.is_drowned = is_drowned | ||
| self.decks = Ship.create_decks(start, end) | ||
|
|
||
| def get_deck(self, row: int, column: int) -> Deck: |
app/main.py
Outdated
Comment on lines
41
to
42
| if ship_begin == ship_end: | ||
| return [Deck(*ship_begin)] |
vasylhnatiuk
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.