Solution #325
Closed
Solution #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVChornyy
approved these changes
Oct 26, 2023
wQuelS
suggested changes
Nov 21, 2023
app/main.py
Outdated
Comment on lines
39
to
40
| deck = self.get_deck(row, column) | ||
| deck.is_alive = False |
There was a problem hiding this comment.
Can your get_deck return None if there is no deck at that location?
If yes, do you think it is safe to use is_alive on the object, that potentially can be None?
Comment on lines
+49
to
+52
| for ship in ships: | ||
| my_ship = Ship(ship[0], ship[1]) | ||
| for deck in my_ship.decks: | ||
| self.field[(deck.row, deck.column)] = my_ship |
There was a problem hiding this comment.
such logic better suited for some separate method, that can be called from this init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.