solution #336
Open
solution #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Oct 30, 2023
|
|
||
| def get_deck(self, row, column): | ||
| def get_deck(self, row: int, column: int) -> Deck: | ||
| # Find the corresponding deck in the list |
app/main.py
Outdated
Comment on lines
45
to
53
| cheker = False | ||
| for decks in self.decks: | ||
| if decks.is_alive is True: | ||
| cheker = True | ||
| break | ||
| if cheker is True: | ||
| self.is_drowned = False | ||
| else: | ||
| self.is_drowned = True |
There was a problem hiding this comment.
You could rewrite this code in one line:
Suggested change
| cheker = False | |
| for decks in self.decks: | |
| if decks.is_alive is True: | |
| cheker = True | |
| break | |
| if cheker is True: | |
| self.is_drowned = False | |
| else: | |
| self.is_drowned = True | |
| self.is_drowned = not any(deck.is_alive for deck in self.decks) |
app/main.py
Outdated
| self.field[location].fire(location[0], location[1]) | ||
| if not self.field[location].is_drowned: | ||
| return "Hit!" | ||
| else: |
There was a problem hiding this comment.
Remove else as mentioned in the checklist.
app/main.py
Outdated
| @@ -1,34 +1,76 @@ | |||
| class Deck: | |||
| def __init__(self, row, column, is_alive=True): | |||
| pass | |||
| def __init__(self, row: int, column: int, is_alive: bool = True) -> None: | |||
There was a problem hiding this comment.
Place all arguments on a new line for better code perception.
app/main.py
Outdated
| self, | ||
| start: tuple, | ||
| end: tuple, | ||
| is_drowned: bool = False |
There was a problem hiding this comment.
You could annotate optional arguments:
Suggested change
| is_drowned: bool = False | |
| is_drowned: bool | None = False |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.