-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement methods #466
Open
anton-bilous
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
anton-bilous:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement methods #466
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,133 @@ | ||
from collections import Counter | ||
from dataclasses import dataclass | ||
from typing import TypeAlias, Iterable | ||
|
||
|
||
Coord: TypeAlias = tuple[int, int] | ||
|
||
|
||
@dataclass | ||
class Deck: | ||
def __init__(self, row, column, is_alive=True): | ||
pass | ||
row: int | ||
column: int | ||
is_alive: bool = True | ||
|
||
|
||
class InvalidCoordsException(Exception): | ||
pass | ||
|
||
|
||
class Ship: | ||
def __init__(self, start, end, is_drowned=False): | ||
# Create decks and save them to a list `self.decks` | ||
pass | ||
def __init__( | ||
self, start: Coord, end: Coord, is_drowned: bool = False | ||
) -> None: | ||
self.is_drowned = is_drowned | ||
|
||
self.decks = [] | ||
if start[0] == end[0]: | ||
for column in range(start[1], end[1] + 1): | ||
self.decks.append(Deck(start[0], column, not is_drowned)) | ||
elif start[1] == end[1]: | ||
for row in range(start[0], end[0] + 1): | ||
self.decks.append(Deck(row, start[1], not is_drowned)) | ||
else: | ||
raise InvalidCoordsException( | ||
"coords passed to Ship() are not valid" | ||
) | ||
|
||
def get_deck(self, row: int, column: int) -> Deck | None: | ||
for deck in self.decks: | ||
if deck.row == row and deck.column == column: | ||
return deck | ||
return None | ||
|
||
def get_deck(self, row, column): | ||
# Find the corresponding deck in the list | ||
pass | ||
def fire(self, row: int, column: int) -> bool: | ||
self.get_deck(row, column).is_alive = False | ||
if all(not deck.is_alive for deck in self.decks): | ||
self.is_drowned = True | ||
return True | ||
return False | ||
|
||
def fire(self, row, column): | ||
# Change the `is_alive` status of the deck | ||
# And update the `is_drowned` value if it's needed | ||
pass | ||
|
||
class InvalidFieldException(Exception): | ||
pass | ||
|
||
|
||
class Battleship: | ||
def __init__(self, ships): | ||
# Create a dict `self.field`. | ||
# Its keys are tuples - the coordinates of the non-empty cells, | ||
# A value for each cell is a reference to the ship | ||
# which is located in it | ||
pass | ||
|
||
def fire(self, location: tuple): | ||
# This function should check whether the location | ||
# is a key in the `self.field` | ||
# If it is, then it should check if this cell is the last alive | ||
# in the ship or not. | ||
pass | ||
FIELD_SIZE = 10 | ||
|
||
def __init__(self, ships: Iterable[tuple[Coord, Coord]]) -> None: | ||
self.field = {} | ||
for start, end in ships: | ||
ship = Ship(start, end) | ||
for deck in ship.decks: | ||
coord = (deck.row, deck.column) | ||
if coord in self.field: | ||
raise InvalidFieldException( | ||
f"cell {coord} is already taken" | ||
) | ||
self.field[coord] = ship | ||
|
||
self._validate_field() | ||
|
||
def fire(self, location: Coord) -> str: | ||
if location not in self.field: | ||
return "Miss!" | ||
if self.field[location].fire(*location): | ||
return "Sunk!" | ||
return "Hit!" | ||
|
||
def print_field(self) -> None: | ||
for row in range(self.FIELD_SIZE): | ||
for column in range(self.FIELD_SIZE): | ||
coords = (row, column) | ||
if coords not in self.field: | ||
print("~", end=" ") | ||
continue | ||
ship = self.field[coords] | ||
if ship.is_drowned: | ||
print("x", end=" ") | ||
elif ship.get_deck(row, column).is_alive: | ||
print("\u25A1", end=" ") | ||
else: | ||
print("*", end=" ") | ||
print() | ||
|
||
def _validate_field(self) -> None: | ||
self._validate_ship_count() | ||
self._validate_ship_positions() | ||
|
||
def _validate_ship_count(self) -> None: | ||
ships = set(self.field.values()) | ||
if len(ships) != 10: | ||
raise InvalidFieldException( | ||
"the total number of the ships should be 10" | ||
) | ||
counter = Counter(len(ship.decks) for ship in ships) | ||
for size, expected_count, verbose_name in ( | ||
(1, 4, "single"), | ||
(2, 3, "double"), | ||
(3, 2, "three"), | ||
(4, 1, "four"), | ||
): | ||
if counter[size] != expected_count: | ||
raise InvalidFieldException( | ||
f"there should be {expected_count} {verbose_name}-deck" | ||
" ship" + ("s" if expected_count != 1 else "") | ||
) | ||
|
||
def _validate_ship_positions(self) -> None: | ||
for row, column in self.field: | ||
current_ship = self.field[(row, column)] | ||
# check nearby cells | ||
for row_adj in range(-1, 2): | ||
for column_adj in range(-1, 2): | ||
coord = (row + row_adj, column + column_adj) | ||
if ( | ||
coord in self.field | ||
and self.field[coord] is not current_ship | ||
): | ||
raise InvalidFieldException( | ||
"ships shouldn't be located in the" | ||
" neighboring cells" | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_deck can return None, thus you'll try to do None.is_alive