Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #467

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 98 additions & 13 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,34 +1,119 @@
class Deck:
def __init__(self, row, column, is_alive=True):
pass
def __init__(self, row: int, column: int, is_alive: bool = True) -> None:
self.row = row
self.column = column
self.is_alive = is_alive


class Ship:
def __init__(self, start, end, is_drowned=False):
def __init__(self,
start: tuple,
end: tuple,
is_drowned: bool = False) -> None:
# Create decks and save them to a list `self.decks`
pass
self.is_drowned = is_drowned
self.decks = [
Deck(row, column)
for row in range(start[0], end[0] + 1)
for column in range(start[1], end[1] + 1)]

def get_deck(self, row, column):
# Find the corresponding deck in the list
pass
def get_deck(self, row: int, column: int) -> Deck | None:
for deck in self.decks:
if row == deck.row and column == deck.column:
return deck

def fire(self, row, column):
def fire(self, row: int, column: int) -> None:
# Change the `is_alive` status of the deck
# And update the `is_drowned` value if it's needed
pass
self.get_deck(row, column).is_alive = False
if any([deck.is_alive for deck in self.decks]) is False:
self.is_drowned = True


class Battleship:
def __init__(self, ships):
def __init__(self, ships: list[tuple]) -> None:
# Create a dict `self.field`.
# Its keys are tuples - the coordinates of the non-empty cells,
# A value for each cell is a reference to the ship
# which is located in it
SkepskyiDanylo marked this conversation as resolved.
Show resolved Hide resolved
pass
self.field = {}
for start, end in ships:
cords = [
(row, column)
for row in range(start[0], end[0] + 1)
for column in range(start[1], end[1] + 1)]
ship = Ship(start, end)
for cord in cords:
self.field[cord] = ship
self._validate_input(ships)

def fire(self, location: tuple):
def fire(self, location: tuple) -> str:
# This function should check whether the location
# is a key in the `self.field`
# If it is, then it should check if this cell is the last alive
# in the ship or not.
pass
ship = self.field.get(location)
if ship:
ship.fire(*location)
if ship.is_drowned is True:
return "Sunk!"
else:
return "Hit!"
else:
return "Miss!"
SkepskyiDanylo marked this conversation as resolved.
Show resolved Hide resolved

def print_field(self) -> None:
for row in range(9 + 1):
for column in range(9 + 1):
ship = self.field.get((row, column))
if ship:
deck = ship.get_deck(row, column)
if ship.is_drowned:
print(" X ", end="")
continue
elif deck.is_alive:
print(u" \u25A1 ", end="")
else:
print(" * ", end="")
else:
print(" ~ ", end="")
print("")

def _validate_input(self, ships: list[tuple]) -> None:
# Check if count of ships == 10
if len(ships) < 10:
raise ValueError(f"Count of ships should be"
f"equal 10, got {len(ships)} instead")
count_of_ships = {
1: 0,
2: 0,
3: 0,
4: 0,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
count_of_ships = {
1: 0,
2: 0,
3: 0,
4: 0,
}
count_of_ships = {1: 0, 2: 0, 3: 0, 4: 0,}

list_of_ships = list(self.field.values())
# Counting each ship type, and adding it to dict
for ship in set(list_of_ships):
count_of_ships[list_of_ships.count(ship)] += 1
# Checking if there is correct count of each ship type
if ([count_of_ships[1], count_of_ships[2],
count_of_ships[3], count_of_ships[4]] != [4, 3, 2, 1]):
raise ValueError(f"There should be: \n"
f"4 one-deck ships, "
f"got {count_of_ships[1]} instead\n"
f"3 double-deck ships, "
f"got {count_of_ships[2]} instead\n"
f"2 three-deck ships, "
f"got {count_of_ships[3]} instead\n"
f"1 four-deck ship, "
f"got {count_of_ships[4]} instead")
# Checking if there ships in neighboring cells
for cord, ship in self.field.items():
for row in range(cord[0] - 1, cord[0] + 2):
for column in range(cord[1] - 1, cord[1] + 2):
self._check_ceil(row, column, ship)

def _check_ceil(self, row: int, column: int, ship: Ship) -> None:
if (self.field.get((row, column))
and self.field.get((row, column)) != ship):
raise ValueError("Ships cannot be in neighboring cells"
"(even if cells are neighbors by diagonal)")
Loading