Resolve #476
Open
Resolve #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNDonut
suggested changes
Aug 30, 2024
app/main.py
Outdated
| @@ -1,34 +1,69 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
why do you need this? Seems like you use ordinary types in annotation
There was a problem hiding this comment.
Not, get_deck function returns Deck object, but it only one place where I using it, so would it be right if I deleted this and just wrote “Deck”, it also works
app/main.py
Outdated
Comment on lines
55
to
56
| ship_instance = Ship(ship[0], ship[1]) | ||
| for deck in Ship(ship[0], ship[1]).decks: |
There was a problem hiding this comment.
- You can use unpacking here
- In the loop use ship_instance variable
app/main.py
Outdated
| # in the ship or not. | ||
| pass | ||
|
|
||
| def __init__(self, ships: list) -> None: |
app/main.py
Outdated
| for deck in Ship(ship[0], ship[1]).decks: | ||
| self.field[(deck.row, deck.column)] = ship_instance | ||
|
|
||
| def fire(self, location: tuple) -> str: |
app/main.py
Outdated
| return "Sunk!" | ||
| else: | ||
| return "Hit!" | ||
| else: |
There was a problem hiding this comment.
No need for else because if statement exactly returns something as there is another else statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.