Solution #517
Solution #517
Conversation
There was a problem hiding this comment.
Great job on implementing the Battleship game! 🎉 Your code meets the task requirements and constraints, and the core functionality is working as expected. There are a few minor improvements you could consider, such as enhancing error messages for better clarity and removing unnecessary line continuation characters for improved readability. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| field[deck.row][deck.column] = "*" if not ship.is_drowned \ | ||
| else "x" |
There was a problem hiding this comment.
The line continuation character \ is used here, which is not necessary as the expression can fit in one line. Consider removing it for better readability.
| if ships_count != {1: 4, 2: 3, 3: 2, 4: 1}: | ||
| raise ValueError("Invalid deck count.") |
There was a problem hiding this comment.
The condition ships_count != {1: 4, 2: 3, 3: 2, 4: 1} checks for the exact number of ships of each size. Ensure that this matches the game rules you intend to implement. If the rules differ, adjust the condition accordingly.
| if ships_count != {1: 4, 2: 3, 3: 2, 4: 1}: | ||
| raise ValueError("Invalid deck count.") | ||
| else: | ||
| raise ValueError("Should be 10 ships.") |
There was a problem hiding this comment.
The error message 'Should be 10 ships.' might be misleading if the number of ships is correct but their sizes are not. Consider providing a more descriptive error message.
No description provided.